Skip to content

PHPORM-256: Disable mongoc_client reuse between connections #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

PHPORM-256: Disable mongoc_client reuse between connections #3197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ protected function createConnection(string $dsn, array $config, array $options):
$options['password'] = $config['password'];
}

if (isset($config['name'])) {
$driverOptions += ['connectionName' => $config['name']];
}

return new Client($dsn, $options, $driverOptions);
}

Expand Down
28 changes: 28 additions & 0 deletions tests/ConnectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,34 @@ public function testQueryLog()
}
}

public function testQueryLogWithMultipleClients()
{
$connection = DB::connection('mongodb');
$this->assertInstanceOf(Connection::class, $connection);

// Create a second connection with the same config as the first
// Make sure to change the name as it's used as a connection identifier
$config = $connection->getConfig();
$config['name'] = 'mongodb2';
$secondConnection = new Connection($config);

$connection->enableQueryLog();
$secondConnection->enableQueryLog();

$this->assertCount(0, $connection->getQueryLog());
$this->assertCount(0, $secondConnection->getQueryLog());

$connection->table('items')->get();

$this->assertCount(1, $connection->getQueryLog());
$this->assertCount(0, $secondConnection->getQueryLog());

$secondConnection->table('items')->get();

$this->assertCount(1, $connection->getQueryLog());
$this->assertCount(1, $secondConnection->getQueryLog());
}

public function testDisableQueryLog()
{
// Disabled by default
Expand Down