Skip to content

feat: exclude system collection in getAllCollection #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat: exclude system collection in getAllCollection #3321

wants to merge 4 commits into from

Conversation

masterbater
Copy link
Contributor

@masterbater masterbater commented Mar 12, 2025 •
edited
Loading

Exclude system collection in getAllCollections which only use by dropAllTables
solves this
#3320

Checklist

  • Add tests and ensure they pass

@masterbater masterbater requested a review from a team as a code owner March 12, 2025 15:29
@masterbater masterbater requested a review from GromNaN March 12, 2025 15:29
@GromNaN
Copy link
Member

GromNaN commented Mar 21, 2025

That's a good idea. In think it should also be done in getTableListing and getTables.
Also, could you add some tests please?

@masterbater masterbater marked this pull request as draft March 24, 2025 11:07
@masterbater
Copy link
Contributor Author

masterbater commented Mar 24, 2025 •
edited
Loading

That's a good idea. In think it should also be done in getTableListing and getTables. Also, could you add some tests please?

Its moved here
#3327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN Awaiting requested review from GromNaN GromNaN is a code owner automatically assigned from mongodb/dbx-php

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masterbater @GromNaN