Skip to content

[5.x] Replaced a too strict assertion in DatabaseSessionHandler.php that prevented to use the sessions at all with a more simple sanity check. Test already failed on that, now they pass. #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2025
Merged

[5.x] Replaced a too strict assertion in DatabaseSessionHandler.php that prevented to use the sessions at all with a more simple sanity check. Test already failed on that, now they pass. #3366

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7aa55fa
[5.x] Replaced a too strict assertion in DatabaseSessionHandler.php t…
Apr 20, 2025
fd9a646
Always check the assert expectations in tests
GromNaN Apr 20, 2025
6911545
Fix CS
GromNaN Apr 20, 2025
04a049f
Set zend.assertions=1
GromNaN Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<env name="QUEUE_CONNECTION" value="database"/>
<ini name="xdebug.mode" value="coverage"/>
<ini name="memory_limit" value="-1"/>
<ini name="zend.assertions" value="1"/>
</php>

<source restrictDeprecations="true"
Expand Down
8 changes: 5 additions & 3 deletions src/Session/MongoDbSessionHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
use MongoDB\BSON\UTCDateTime;
use MongoDB\Collection;

use function assert;
use function tap;
use function time;

Expand Down Expand Up @@ -56,9 +55,12 @@ public function read($sessionId): string|false
'typeMap' => ['root' => 'bson'],
],
);
assert($result instanceof Document);

return $result ? (string) $result->payload : false;
if ($result instanceof Document) {
return (string) $result->payload;
}

return false;
}

public function write($sessionId, $data): bool
Expand Down
Loading