-
Notifications
You must be signed in to change notification settings - Fork 1.4k
DOCSP-50472: schema validation #3400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
1c45cb2
aa5e8cf
a6e72f5
737a009
24152bb
1073888
ea1d3a6
84e8c85
e425c9a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -21,8 +21,9 @@ Overview | |||||||||||||||||||||||||||
-------- | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
Laravel provides a **facade** to access the schema builder class ``Schema``, | ||||||||||||||||||||||||||||
which lets you create and modify tables. Facades are static interfaces to | ||||||||||||||||||||||||||||
classes that make the syntax more concise and improve testability. | ||||||||||||||||||||||||||||
which lets you create and modify tables, or collections in MongoDB. | ||||||||||||||||||||||||||||
Facades are static interfaces to classes that make the syntax more | ||||||||||||||||||||||||||||
concise and improve testability. | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
The {+odm-short+} supports a subset of the index and collection management methods | ||||||||||||||||||||||||||||
in the Laravel ``Schema`` facade. | ||||||||||||||||||||||||||||
|
@@ -33,16 +34,10 @@ in the Laravel documentation. | |||||||||||||||||||||||||||
The following sections describe the Laravel schema builder features available | ||||||||||||||||||||||||||||
in the {+odm-short+} and show examples of how to use them: | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
- :ref:`<laravel-eloquent-migrations>` | ||||||||||||||||||||||||||||
- :ref:`<laravel-eloquent-collection-exists>` | ||||||||||||||||||||||||||||
- :ref:`<laravel-eloquent-indexes>` | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
.. note:: | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
The {+odm-short+} supports managing indexes and collections, but | ||||||||||||||||||||||||||||
excludes support for MongoDB JSON schemas for data validation. To learn | ||||||||||||||||||||||||||||
more about JSON schema validation, see :manual:`Schema Validation </core/schema-validation/>` | ||||||||||||||||||||||||||||
in the {+server-docs-name+}. | ||||||||||||||||||||||||||||
- :ref:`laravel-eloquent-migrations` | ||||||||||||||||||||||||||||
- :ref:`laravel-eloquent-schema-validation` | ||||||||||||||||||||||||||||
- :ref:`laravel-eloquent-collection-exists` | ||||||||||||||||||||||||||||
- :ref:`laravel-eloquent-indexes` | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
.. _laravel-eloquent-migrations: | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
|
@@ -117,6 +112,63 @@ To learn more about Laravel migrations, see | |||||||||||||||||||||||||||
`Database: Migrations <https://laravel.com/docs/{+laravel-docs-version+}/migrations>`__ | ||||||||||||||||||||||||||||
in the Laravel documentation. | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
.. _laravel-eloquent-schema-validation: | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
Implement Schema Validation | ||||||||||||||||||||||||||||
--------------------------- | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
You can use the ``jsonSchema()`` method to implement :manual:`schema | ||||||||||||||||||||||||||||
validation </core/schema-validation/>` when using the following schema | ||||||||||||||||||||||||||||
builder methods: | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
- ``Schema::create()``: When creating a new collection | ||||||||||||||||||||||||||||
- ``Schema::table()``: When updating collection properties | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
After you implement schema validation, the server allows you to run only | ||||||||||||||||||||||||||||
those write operations which follow the validation rules. Use schema | ||||||||||||||||||||||||||||
|
those write operations which follow the validation rules. Use schema | |
those write operations that follow the validation rules. Use schema |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: i wonder if the connection between these two sentences would be clearer if you switched them. something like:
After you implement schema validation, the server allows you to run only | |
those write operations which follow the validation rules. Use schema | |
validation to restrict data types and value ranges of document fields in | |
a specified collection. | |
You can use schema validation to restrict data types and value ranges of document fields in | |
a specified collection. After you implement schema validation, the server allows you to run only | |
those write operations which follow the validation rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$jsonSchema
doesn't need to be included in the schema argument (see the example). Since the method is Blueprint::jsonSchema
, the '$jsonSchema'
operation is already implied.
So this documentation may be valid for MongoDB server but not for Laravel usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh also! Since this is PHP, the schema argument is not an object, but an associative array.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: break up paragraphs differently. could also then remove first 'JSON'
Before creating a collection with schema validation rules, you must | |
define a JSON schema. | |
The schema is a JSON object that contains key-value pairs | |
specifying the validation rules for your collection. At the top level, | |
this object must include a ``$jsonSchema`` object. The ``$jsonSchema`` | |
object can include the following fields: | |
Before creating a collection with schema validation rules, you must | |
define the schema. | |
A schema is a JSON object that contains key-value pairs | |
specifying the validation rules for your collection. | |
At the top level, this object must include a ``$jsonSchema`` object. The ``$jsonSchema`` | |
object can include the following fields: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this paragraph per PV suggestion
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we actually include this documentation? Seems to me the $jsonSchema
operation is covered by the Mongo server docs. The Laravel ORM passes the schema through as is. I think specifying allowed fields here puts us in a situation of having to update this documentation when Mongo server specs change, when the user could just use the Mongo server docs as the single source of truth for jsonSchema usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense - I'll cut out some of this text and apply the suggestions from your prev comment.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: no periods
- ``title``: Sets an optional title for the schema. | |
- ``required``: Specifies a list of required fields for each document in your collection. | |
- ``properties``: Sets property requirements for individual fields. | |
- ``title``: Sets an optional title for the schema | |
- ``required``: Specifies a list of required fields for each document in your collection | |
- ``properties``: Sets property requirements for individual fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this text
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S:
contain the ``license_number`` field with an integer value between | |
contain the ``license_number`` field, and the field must have an integer value between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to a list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: can you only implement schema validation when using these methods for these specific purposes? or is the info after the colons just a reminder of the method's purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the only two methods in Laravel's
Schema
that accept a callback to alter columns, so you can only implement schema validation on either creating a collection or updating it.