Chore: apply ExplicitNullableParamTypeRector rule #3438
Closed
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Hello @zigzagdev, I appreciate your willingness to contribute to the project, but these changes are not relevant. I'm closing.
| @@ -16,6 +17,9 @@ | |||
| ]) | |||
| ->withPhpSets() | |||
| ->withTypeCoverageLevel(0) | |||
| ->withRules([ | |||
| ExplicitNullableParamTypeRector::class, | |||
There was a problem hiding this comment.
This rule did not fix anything in the codebase. The explicit nullable params are already fixed by phpcs.
Comment on lines
+72
to
+73
| private readonly Database $database, | ||
| private readonly bool $softDelete, |
There was a problem hiding this comment.
We don't need to protect private properties with readonly, their usage is internal to this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=> I run rector test and attach my test results.
