-
Notifications
You must be signed in to change notification settings - Fork 71
useControlledValue updates [LG-3608] #1953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
753ba16
Extends `useControlledValue` to accept any type
TheSonOfThomp eec25b7
Merge branch 'main' into adam/generic-useControlledValue
TheSonOfThomp c565f26
Adds more explicit tests
TheSonOfThomp b612835
adds test component tests
TheSonOfThomp f4e1c61
adds value tests
TheSonOfThomp bbb1832
isControlled never changes from initial render
TheSonOfThomp af6cc48
adds synthetic events
TheSonOfThomp f6751e8
adds initialValue & warning
TheSonOfThomp 4f37e4b
Merge branch 'main' into adam/generic-useControlledValue
TheSonOfThomp 0fd6d6b
Update useControlledValue.spec.tsx
TheSonOfThomp 405229a
resolves circular dependency in lib
TheSonOfThomp 152db57
expect no console
TheSonOfThomp 3d0abb5
Merge branch 'main' into adam/generic-useControlledValue
TheSonOfThomp 50a45ae
Adds NextLink legacyBehavior test
TheSonOfThomp d2377e7
Merge branch 'fix-button-test-next' into adam/generic-useControlledValue
TheSonOfThomp 80dc30c
rm lib from dev dep
TheSonOfThomp a1c34e9
Merge branch 'main' into adam/generic-useControlledValue
TheSonOfThomp a697215
Update useControlledValue.spec.tsx
TheSonOfThomp 7a833ae
updates useControlled value to be more flexible
TheSonOfThomp cf61a27
add warnings
TheSonOfThomp d4af1bd
Update soft-berries-obey.md
TheSonOfThomp 799a672
Merge branch 'main' into adam/generic-useControlledValue
TheSonOfThomp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'@leafygreen-ui/hooks': minor | ||
--- | ||
|
||
- Extends `useControlledValue` to accept any type. | ||
- Adds `updateValue` function in return value. This method triggers a synthetic event to update the value of a controlled or uncontrolled component. | ||
- Adds `initialValue` argument. Used for setting the initial value for uncontrolled components. Without this we may encounter a React error for switching between controlled/uncontrolled inputs | ||
- The value of `isControlled` is now immutable after the first render |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 0 additions & 43 deletions
43
packages/hooks/src/useControlledValue/useControlledValue.spec.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.