fix(message): remove standalone MessagePromotion export #3180
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephl3
requested review from
Copilot and
shaneeza
and removed request for
a team
🦋 Changeset detectedLatest commit: b49050c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the standalone MessagePromotion component export from @lg-chat/message while preserving the MessagePromotionProps type export. This change enforces the compound component pattern where MessagePromotion should only be accessed as Message.Promotion rather than as a standalone import.
Key changes:
- Removes
MessagePromotioncomponent from standalone exports - Retains
MessagePromotionPropstype export for TypeScript usage - Adds changeset documentation for the breaking change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| chat/message/src/index.ts | Updates exports to remove standalone MessagePromotion component while keeping type export |
| .changeset/rude-rockets-crash.md | Documents the breaking change for release notes |
|
Size Change: -9 B (0%) Total Size: 1.6 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Oct 6, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@lg-chat/message': patch | |||
There was a problem hiding this comment.
Why is this only a patch?
There was a problem hiding this comment.
@shaneeza it was inadvertently exported in the previous release. I was treating this as a fix and going to deprecate the version that initially exported it since it doesn't yet have usage. Do you think that would be fine or does this need to be a major version?
There was a problem hiding this comment.
Honestly, I'm not sure. I would bring it up with the team.
There was a problem hiding this comment.
Synced offline and we deemed patch was okay in this case despite this technically being a major
shaneeza
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Removes the standalone
MessagePromotionexport from@lg-chat/messagewhile keeping theMessagePromotionPropstype export. This change aligns with the compound component pattern introduced in v8.2.0, whereMessagePromotionshould only be accessed asMessage.Promotion, not as a standalone export.The component remains fully functional as
Message.Promotion, and TypeScript users can still import theMessagePromotionPropstype for type checking.🎟️ Jira ticket: No JIRA ticket found in changeset files
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
Message.Promotioncontinues to work as expected when used as a compound componentMessagePromotionPropscan still be imported for TypeScript type checkingMessagePromotionas a standalone component results in an error (expected behavior)Message.Promotionfunctionality is unchanged