-
Notifications
You must be signed in to change notification settings - Fork 71
[LG-5098] feat(CodeEditor): adds custom search panel #3186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tsck
wants to merge
36
commits into
main
Choose a base branch
from
LG-5098/ce-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
c6bd1bc
feat(SearchForm): add SearchForm component
tsck 58544a5
feat(SearchForm): implement SearchForm component with toggle function…
tsck 56e3da1
refactor(CodeEditor): add back in panel import
tsck 5eded55
refactor(SearchForm): further correct styling
tsck d978333
WIP
tsck fa6c306
refactor(SearchForm): Further correct styling
tsck e830312
make top row height more dynamic
tsck 933b80d
fix top section height
tsck 907cbb4
WIP
tsck a498900
Fix width styling
tsck 3f9b74a
Fix box shadow
tsck f904171
Add find functionality
tsck 67ecba2
Remove unnecessary space
tsck 78f21f0
Add find selected index rendering
tsck 9b8c567
Add replace functionality
tsck 15d794d
Fix keyboard shortcuts
tsck df1cb0f
rename SearchForm to SearchPanel
tsck 25a3733
fix top padding
tsck 561ecac
Allow search panel to be disabled
tsck 98257bd
fix dep array
tsck 9bfa487
only load search module when needed
tsck b717e1d
fix darkmode and font size
tsck 055634a
fix deps
tsck c1226bf
Fix focus and imports
tsck 7185fd7
prevent panel from overflowing editor
tsck 32806fe
add filter menu
tsck 7847be3
pull out all handler
tsck 4b9d033
add search panel tests
tsck 9cb57dc
fix tests
tsck 27cdca2
changeset
tsck 008a7e7
remove unused styles
tsck de4fb39
update changeset
tsck 5174e64
ignore react client TS issue
tsck 4e628f3
add non-panel style
tsck b5d2777
fix dep arr
tsck d743a1b
Fix react 17 bug
tsck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@leafygreen-ui/code-editor': minor | ||
--- | ||
|
||
- Adds a custom search panel to the `CodeEditor` component. Contains all of the same functionality that was in the built in panel but matches the LG design language. | ||
- Adds prop to allow consumers to enable/disable the search panel. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected extra parenthesis and underscore formatting in the table row.
Copilot uses AI. Check for mistakes.