-
Notifications
You must be signed in to change notification settings - Fork 72
[LG-5562] feat(Wizard) Updates Wizard API
#3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
private endpoints useFetchRequiredActionTableData renam ReqAct cards composable basic table stream processing card federated db card applications card clusters card wizard step context Delete requiredActionsConfig.tsx re-enable wizard add useRequiredActionAcknowledgements mv required action. add skeleton Update ModelApiKeysCard.tsx
Update package.json
🦋 Changeset detectedLatest commit: 4b32ed6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +445 B (+0.02%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
2298793 to
cbb87fe
Compare
Wizard API for simpler implementation
Wizard API for simpler implementationWizard API
shaneeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I mostly left minor comments as well as some comments in chromatic.
|
Coverage after merging LG-5562-wizard-updates into at/wizard-integration will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* rm step wrapper * rm descendants dep * export WizardProvider * delete-wizard-demo private endpoints useFetchRequiredActionTableData renam ReqAct cards composable basic table stream processing card federated db card applications card clusters card wizard step context Delete requiredActionsConfig.tsx re-enable wizard add useRequiredActionAcknowledgements mv required action. add skeleton Update ModelApiKeysCard.tsx * Update pnpm Update package.json * fix wizard changes * Adds `requiresAcknowledgement` prop to Wizard.Step * Implements `isAcknowledged` state inside provider * Update Wizard.stories.tsx * rm delete demo * Update wizard.md * rm temp changesets * Update README.md * Update WizardStep.spec.tsx * footer tests * Update Wizard.spec.tsx * update package json * update provider props * revert toast changes? * Update .npmrc * Update pnpm-lock.yaml * Update WizardStep.spec.tsx * exports form footer types * Update WizardFooter.types.ts * adds `totalSteps` to wizard context * fix bad merge * updates readme * updates tsdoc * fixes tests * fixes ack reset test * Update WizardStep.spec.tsx * fixes stories
✍️ Proposed changes
Part of a PR train:
Wizard#3338DeleteWizardtemplate package #3291Integration branch: #3152
'@leafygreen-ui/wizard': minor
Initial Wizard package release.
Wizard
The
Wizardcomponent establishes a context with an internal state, and will render only theactiveStep.You can also control the Wizard externally using the
activeStepandonStepChangecallback.Note: if you externally control the state, you opt out of the automatic range validation, and you must ensure that the provided
activeStepindex is valid relative to theWizard.Steps provided.Wizard.Step
Defines a discrete step in the wizard. Only the step matching the internal (or provided)
activeStepindex will be displayed.Both
WizardandWizard.Stepare only wrapped in aFragmentto allow for more versatile styling.requiresAcknowledgementIf
requiresAcknowledgementis true, the step must haveisAcknowledgedset in context, (or passed in as a controlled prop) for the Footer's primary button to be enabled.e.g.
Wizard.Footer
The
Wizard.Footeris a convenience wrapper around theFormFootercomponent. Each step should render its own Footer component