Skip to content

refactor(guide-cue): update test #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

refactor(guide-cue): update test #3337

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a986023
fix(GuideCue): streamline button focus test by removing unnecessary w…
shaneeza Nov 21, 2025
fbacfa0
wip
shaneeza Nov 21, 2025
9e79f82
Remove debug logging from ListMenu component
shaneeza Nov 21, 2025
d4efa9d
fix(GuideCue): update button focus test for clarity and accuracy
shaneeza Nov 21, 2025
07b5731
Merge branch 'main' of github.com:mongodb/leafygreen-ui into shaneeza…
shaneeza Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions packages/guide-cue/src/GuideCue/GuideCue.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,18 +186,19 @@ describe('packages/guide-cue', () => {
expect(body).toBeInTheDocument();
});

test('primary button is focusable for focus trap targeting', async () => {
test('primary button is focused when opened', async () => {
const { getByRole } = renderGuideCue({
open: true,
});

const primaryButton = getByRole('button', { name: buttonTextDefault });
expect(primaryButton).toBeInTheDocument();

userEvent.tab();
await waitFor(() => {
expect(primaryButton).toHaveFocus();
expect(getByRole('dialog')).toBeVisible(); // Checks visibility. If the dialog is visible, then the focus trap is in effect and the primary button is focused.
});

const primaryButton = getByRole('button', { name: buttonTextDefault });
expect(primaryButton).toBeInTheDocument();
// This should automatically be in focus when the guidecue is opened.
expect(primaryButton).toHaveFocus();
});
});

Expand Down Expand Up @@ -367,23 +368,21 @@ describe('packages/guide-cue', () => {
await waitFor(() => expect(numOfButtons).toEqual(2));
});

test('primary button is focusable for focus trap targeting', async () => {
test('primary button is focused when opened', async () => {
const { getByRole } = renderGuideCue({
open: true,
numberOfSteps: 2,
currentStep: 1,
});
await act(async () => {
await waitForTimeout(timeout1);

await waitFor(() => {
expect(getByRole('dialog')).toBeVisible(); // Checks visibility. If the dialog is visible, then the focus trap is in effect and the primary button is focused.
});

const primaryButton = getByRole('button', { name: buttonTextDefault });
expect(primaryButton).toBeInTheDocument();

userEvent.tab();
await waitFor(() => {
expect(primaryButton).toHaveFocus();
});
// This should automatically be in focus when the guidecue is opened.
expect(primaryButton).toHaveFocus();
});
});
});
Loading