Skip to content

PYTHON-5017 Use a separate PyPI publish step #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 2 commits into from
Dec 31, 2024
Merged

PYTHON-5017 Use a separate PyPI publish step #930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c8de2
PYTHON-5017 Use a separate PyPI publish step
blink1073 Dec 31, 2024
67a3824
address review
blink1073 Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/release-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,23 @@ jobs:

publish:
Copy link
Member

@ShaneHarvey ShaneHarvey Dec 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add?:

needs: [build-dist, ...

Otherwise how does this job know that the build step completed?

Copy link
Member Author

@blink1073 blink1073 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

needs: [build-dist, static-scan]
name: Upload release to PyPI
runs-on: ubuntu-latest
environment: release
permissions:
id-token: write
steps:
- name: Download all the dists
uses: actions/download-artifact@v4
with:
name: all-dist-${{ github.run_id }}
path: dist/
- name: Publish package distributions to PyPI
if: inputs.dry_run == 'false'
uses: pypa/gh-action-pypi-publish@release/v1

post-publish:
needs: [publish]
runs-on: ubuntu-latest
environment: release-python
permissions:
Expand Down
Loading