CDRIVER-5698 remove bson_string_t (#1917)

Author: kevinAlbs

NEWS

@@ -17,6 +17,7 @@ Unreleased (2.0.0)
 * `MONGOC_QUERY_SLAVE_OK` is removed. Use the equivalent `MONGOC_QUERY_SECONDARY_OK` instead.
 * `MONGOC_URI_SLAVEOK` is removed. It was unused.
 * `mongoc_collection_save` is removed. Use `mongoc_collection_insert_one` or `mongoc_collection_replace_one` instead.
+* `bson_string_t` and associated functions are removed.
 * `mongoc_cursor_is_alive` is removed. Use the equivalent `mongoc_cursor_more` instead.
 * `mongoc_collection_delete` is removed. Use `mongoc_collection_delete_one` or `mongoc_collection_delete_many` instead.
 * `mongoc_delete_flags_t` and `mongoc_reply_flags_t` are removed.

src/common/src/common-string-private.h

@@ -24,9 +24,7 @@
 #include <string.h>
 
 
-/* Until the deprecated bson_string_t is removed, this must have the same members in the same order, so we can safely
- * cast between the two types. Afterward, we are free to modify the memory layout as needed.
- *
+/*
  * In mcommon_string_t, 'str' is guaranteed to be NUL terminated and SHOULD be valid UTF-8. mcommon_string_t operations
  * MUST maintain the validity of valid UTF-8 strings.
  *

src/libbson/doc/api.rst

@@ -15,7 +15,6 @@ API Reference
   bson_oid_t
   bson_reader_t
   character_and_string_routines
-  bson_string_t
   bson_subtype_t
   bson_type_t
   bson_unichar_t