CDRIVER-5701 remove deprecated bson_as_json and bson_array_as_json (#1920)

* remove `bson_as_json` and `bson_array_as_json`
* use consistent markdown format with libmongoc 2.0 NEWS

Author: kevinAlbs

src/libbson/NEWS

@@ -1,10 +1,14 @@
 libbson 2.0.0 (Unreleased)
 ==========================
 
-Changes:
+## Changes
+
+* `BSON_ERROR_BUFFER_SIZE` is reduced from `504` to `503` to reserve the final byte for internal use.
+    * The data layout of `bson_error_t` remains otherwise unchanged: the size is still 512 bytes and the offset of the `.code`, `.domain`, and `.message` data members remain unchanged.
+
+## Removals
 
-  * `BSON_ERROR_BUFFER_SIZE` is reduced from `504` to `503` to reserve the final byte for internal use.
-      * The data layout of `bson_error_t` remains otherwise unchanged: the size is still 512 bytes and the offset of the `.code`, `.domain`, and `.message` data members remain unchanged.
+* `bson_as_json` and `bson_array_as_json` are removed due to producing non-portable Legacy Extended JSON. Prefer Canonical Extended JSON or Relaxed Extended JSON for portability. To continue using Legacy Extended JSON, use `bson_as_legacy_extended_json` and `bson_array_as_legacy_extended_json`.
 
 libbson 1.30.2
 ==============

src/libbson/doc/bson_array_as_json.rst

@@ -195,11 +195,9 @@ BSON document contains duplicate keys.
     bson_append_utf8
     bson_append_value
     bson_array_as_canonical_extended_json
-    bson_array_as_json
     bson_array_as_legacy_extended_json
     bson_array_as_relaxed_extended_json
     bson_as_canonical_extended_json
-    bson_as_json
     bson_as_json_with_opts
     bson_as_legacy_extended_json
     bson_as_relaxed_extended_json

src/libbson/doc/bson_as_json.rst

@@ -2505,12 +2505,6 @@ bson_as_canonical_extended_json (const bson_t *bson, size_t *length)
 }
 
 
-char *
-bson_as_json (const bson_t *bson, size_t *length)
-{
-   return bson_as_legacy_extended_json (bson, length);
-}
-
 char *
 bson_as_legacy_extended_json (const bson_t *bson, size_t *length)
 {
@@ -2527,12 +2521,6 @@ bson_as_relaxed_extended_json (const bson_t *bson, size_t *length)
 }
 
 
-char *
-bson_array_as_json (const bson_t *bson, size_t *length)
-{
-   return bson_array_as_legacy_extended_json (bson, length);
-}
-
 char *
 bson_array_as_legacy_extended_json (const bson_t *bson, size_t *length)
 {

src/libbson/doc/bson_t.rst

@@ -519,7 +519,7 @@ bson_as_canonical_extended_json (const bson_t *bson, size_t *length);
 
 
 /**
- * bson_as_json:
+ * bson_as_legacy_extended_json:
  * @bson: A bson_t.
  * @length: A location for the string length, or NULL.
  *
@@ -531,10 +531,7 @@ bson_as_canonical_extended_json (const bson_t *bson, size_t *length);
  *
  * Returns: A newly allocated string that should be freed with bson_free().
  */
-BSON_DEPRECATED_FOR (bson_as_legacy_extended_json)
-BSON_EXPORT (char *) bson_as_json (const bson_t *bson, size_t *length);
 
-// `bson_as_legacy_extended_json` is a non-deprecated form of `bson_as_json`.
 BSON_EXPORT (char *)
 bson_as_legacy_extended_json (const bson_t *bson, size_t *length);
 
@@ -561,11 +558,7 @@ BSON_EXPORT (char *)
 bson_as_relaxed_extended_json (const bson_t *bson, size_t *length);
 
 
-/* like bson_as_json() but for outermost arrays. */
-BSON_DEPRECATED_FOR (bson_array_as_legacy_extended_json)
-BSON_EXPORT (char *) bson_array_as_json (const bson_t *bson, size_t *length);
-
-// `bson_array_as_legacy_extended_json` is a non-deprecated form of `bson_array_as_json`.
+/* like bson_as_legacy_extended_json() but for outermost arrays. */
 BSON_EXPORT (char *)
 bson_array_as_legacy_extended_json (const bson_t *bson, size_t *length);