Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2025

Updates libmongoc for compatibility with a proposed spec and test change affecting the packed_bit BSON Binary Vector format:

mongodb/specifications#1783

  • Copy updated spec test
  • Remove obsolete workarounds
  • modification to append_vector_packed_bit_from_packed_array(), asking it to treat masked writes as a conversion failure. (This "from packed array" operation is only for spec tests and doesn't otherwise exist in our API.)

@ghost ghost requested review from kevinAlbs and eramongodb April 4, 2025 22:38
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback; otherwise, LGTM.

@kevinAlbs kevinAlbs changed the title Update libmongoc for DRIVERS-3123 packed_bit change CDRIVER-5979 Update libmongoc for DRIVERS-3123 packed_bit change Apr 9, 2025
@ghost ghost merged commit 247a67f into mongodb:master Apr 9, 2025
40 of 42 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants