CSHARP-3552: CSOT: Transactions #1745
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System; | ||
| using MongoDB.Driver.Core.Misc; | ||
|
|
||
| namespace MongoDB.Driver | ||
| { | ||
| // TODO: CSOT: Make it public when CSOT will be ready for GA | ||
| internal sealed class AbortTransactionOptions | ||
| { | ||
| public AbortTransactionOptions() | ||
| {} | ||
|
|
||
| public AbortTransactionOptions(TimeSpan? timeout) | ||
| { | ||
| Timeout = Ensure.IsNullOrValidTimeout(timeout, nameof(timeout)); | ||
| } | ||
|
|
||
| public TimeSpan? Timeout { get; } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System; | ||
| using MongoDB.Driver.Core.Misc; | ||
|
|
||
| namespace MongoDB.Driver | ||
| { | ||
| // TODO: CSOT: Make it public when CSOT will be ready for GA | ||
| internal sealed class CommitTransactionOptions | ||
| { | ||
| public CommitTransactionOptions() | ||
| {} | ||
|
There was a problem hiding this comment. same no need for a new line? There was a problem hiding this comment. I suppose we do not need the parameter less constructor at all here. Thank you for bringing attention to this. |
||
|
|
||
| public CommitTransactionOptions(TimeSpan? timeout) | ||
| { | ||
| Timeout = Ensure.IsNullOrValidTimeout(timeout, nameof(timeout)); | ||
| } | ||
|
|
||
| public TimeSpan? Timeout { get; } | ||
| } | ||
|
|
||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace MongoDB.Driver.Core.Bindings | ||
| { | ||
| // TODO: CSOT: Make it public when CSOT will be ready for GA | ||
| internal static class ICoreSessionExtensions | ||
|
There was a problem hiding this comment. I recommend creating a new These extension methods are useful to make it "look" (to us) like the new methods are already part of These extension methods should cast There was a problem hiding this comment. All classes that implement |
||
| { | ||
| // TODO: CSOT: Merge this extension methods in ICoreSession interface on major release | ||
| /// <summary> | ||
| /// Aborts the transaction. | ||
| /// </summary> | ||
| /// <param name="session">The session.</param> | ||
| /// <param name="options">Abort transaction options.</param> | ||
| /// <param name="cancellationToken">The cancellation token.</param> | ||
| public static void AbortTransaction(this ICoreSession session, AbortTransactionOptions options, CancellationToken cancellationToken = default) | ||
| { | ||
| if (options == null || session.Options.DefaultTransactionOptions?.Timeout == options.Timeout) | ||
| { | ||
| session.AbortTransaction(cancellationToken); | ||
|
There was a problem hiding this comment. Forwarding the new method to the old method doesn't seem necessary but it also doesn't do any real harm other than adding more lines of code that probably aren't needed. There was a problem hiding this comment. I've decided to have this forwarding, just in case there are any external implementation of ICoreSession, this forwarding might reduce risk of breaking client's code. |
||
| return; | ||
| } | ||
|
|
||
| if (session is CoreSession coreSession) | ||
| { | ||
| coreSession.AbortTransaction(options, cancellationToken); | ||
| return; | ||
| } | ||
|
|
||
| if (session is WrappingCoreSession wrappingCoreSession) | ||
| { | ||
| wrappingCoreSession.AbortTransaction(options, cancellationToken); | ||
| return; | ||
| } | ||
|
|
||
| throw new InvalidOperationException("Cannot apply options on non CoreSession."); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Aborts the transaction. | ||
| /// </summary> | ||
| /// <param name="session">The session.</param> | ||
| /// <param name="options">Abort transaction options.</param> | ||
| /// <param name="cancellationToken">The cancellation token.</param> | ||
| public static Task AbortTransactionAsync(this ICoreSession session, AbortTransactionOptions options, CancellationToken cancellationToken = default) | ||
| { | ||
| if (options == null || session.Options.DefaultTransactionOptions?.Timeout == options.Timeout) | ||
| { | ||
| return session.AbortTransactionAsync(cancellationToken); | ||
| } | ||
|
|
||
| if (session is CoreSession coreSession) | ||
| { | ||
| return coreSession.AbortTransactionAsync(options, cancellationToken); | ||
| } | ||
|
|
||
| if (session is WrappingCoreSession wrappingCoreSession) | ||
| { | ||
| return wrappingCoreSession.AbortTransactionAsync(options, cancellationToken); | ||
| } | ||
|
|
||
| throw new InvalidOperationException("Cannot apply options on non CoreSession."); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Commits the transaction. | ||
| /// </summary> | ||
| /// <param name="session">The session.</param> | ||
| /// <param name="options">Commit transaction options.</param> | ||
| /// <param name="cancellationToken">The cancellation token.</param> | ||
| public static void CommitTransaction(this ICoreSession session, CommitTransactionOptions options, CancellationToken cancellationToken = default) | ||
| { | ||
| if (options == null || session.Options.DefaultTransactionOptions?.Timeout == options.Timeout) | ||
| { | ||
| session.CommitTransaction(cancellationToken); | ||
| return; | ||
| } | ||
|
|
||
| if (session is CoreSession coreSession) | ||
| { | ||
| coreSession.CommitTransaction(options, cancellationToken); | ||
| return; | ||
| } | ||
|
|
||
| if (session is WrappingCoreSession wrappingCoreSession) | ||
| { | ||
| wrappingCoreSession.CommitTransaction(options, cancellationToken); | ||
| return; | ||
| } | ||
|
|
||
| throw new InvalidOperationException("Cannot apply options on non CoreSession."); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Commits the transaction. | ||
| /// </summary> | ||
| /// <param name="session">The session.</param> | ||
| /// <param name="options">Commit transaction options.</param> | ||
| /// <param name="cancellationToken">The cancellation token.</param> | ||
| public static Task CommitTransactionAsync(this ICoreSession session, CommitTransactionOptions options, CancellationToken cancellationToken = default) | ||
| { | ||
| if (options == null || session.Options.DefaultTransactionOptions?.Timeout == options.Timeout) | ||
| { | ||
| return session.CommitTransactionAsync(cancellationToken); | ||
| } | ||
|
|
||
| if (session is CoreSession coreSession) | ||
| { | ||
| return coreSession.CommitTransactionAsync(options, cancellationToken); | ||
| } | ||
|
|
||
| if (session is WrappingCoreSession wrappingCoreSession) | ||
| { | ||
| return wrappingCoreSession.CommitTransactionAsync(options, cancellationToken); | ||
| } | ||
|
|
||
| throw new InvalidOperationException("Cannot apply options on non CoreSession."); | ||
| } | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for a new line for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we do not need the parameter less constructor at all here. Thank you for bringing attention to this.