Skip to content

Conversation

sanych-sun
Copy link
Member

No description provided.

@sanych-sun sanych-sun requested a review from a team as a code owner August 11, 2025 20:29
@sanych-sun sanych-sun requested review from ajcvickers, rstam and adelinowona and removed request for a team and ajcvickers August 11, 2025 20:29
Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -41,17 +40,23 @@ public CommandMessageFieldEncryptor(IBinaryCommandFieldEncryptor commandFieldEnc
}

// public static methods
Copy link
Contributor

@adelinowona adelinowona Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment suggests the methods below are static but they aren't. So maybe update that comment? same for the private methods too.

Copy link
Contributor

@adelinowona adelinowona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left a single comment you can address if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants