CSHARP-3540: CSOT: Client-side encryption#1753
Open
sanych-sun wants to merge 1 commit intomongodb:mainfrom
Open
CSHARP-3540: CSOT: Client-side encryption#1753sanych-sun wants to merge 1 commit intomongodb:mainfrom
sanych-sun wants to merge 1 commit intomongodb:mainfrom
Conversation
sanych-sun
requested review from
adelinowona,
ajcvickers and
rstam
and removed request for
a team and
ajcvickers
adelinowona
reviewed
Aug 26, 2025
| @@ -41,17 +40,23 @@ public CommandMessageFieldEncryptor(IBinaryCommandFieldEncryptor commandFieldEnc | |||
| } | |||
|
|
|||
| // public static methods | |||
Contributor
There was a problem hiding this comment.
the comment suggests the methods below are static but they aren't. So maybe update that comment? same for the private methods too.
adelinowona
approved these changes
Aug 26, 2025
Contributor
adelinowona
left a comment
adelinowona
left a comment
There was a problem hiding this comment.
LGTM just left a single comment you can address if you agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.