CSHARP-5581: Test MONGODB-X509 on cloud-dev #1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
previously approved these changes
Aug 18, 2025
| { | ||
| RequireServer.Check().Tls(required: true); | ||
|
|
||
| string path, password; |
There was a problem hiding this comment.
Minor: It's unusual to have multiple variables declaration in a single line.
| switch (certificateType) | ||
| { | ||
| case CertificateType.MONGO_X509: | ||
| RequireEnvironment.Check() |
There was a problem hiding this comment.
I would suggest to reorganize the code a little: set the names of env variables inside the switch, but read the values out side. Something like this:
string cert_path_variable;
switch (certificateType)
{
case CertificateType.MONGO_X509:
cert_path_variable= MONGODB_X509_CLIENT_CERTIFICATE_PATH;
break;
...
}
RequireEnvironment.Check().EnvironmentVariable(cert_path_variable);
var path = Environment.GetEnvironmentVariable(cert_path_variable);
papafe
added a commit
to papafe/mongo-csharp-driver
that referenced
this pull request
Aug 21, 2025
papafe
added a commit
to papafe/mongo-csharp-driver
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.