-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5798: Implement test to track if any UnobservedTaskExceptions were raised while test run #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CSHARP-5798: Implement test to track if any UnobservedTaskExceptions were raised while test run #1836
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6b9eb50
CSHARP-5798: Implement test to track if any UnobservedTaskExceptions …
sanych-sun 83e8b52
pr
sanych-sun 1c3449e
CSHARP-5798: Implement test to track if any UnobservedTaskExceptions …
sanych-sun b8ab963
PR
sanych-sun 823a0f7
pr
sanych-sun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,8 @@ namespace MongoDB.Driver.Core.Connections | |
| /// </summary> | ||
| internal sealed class TcpStreamFactory : IStreamFactory | ||
| { | ||
| private static readonly byte[] __ensureConnectedBuffer = new byte[1]; | ||
|
|
||
| // fields | ||
| private readonly TcpStreamSettings _settings; | ||
|
|
||
|
|
@@ -165,10 +167,17 @@ private void ConfigureConnectedSocket(Socket socket) | |
|
|
||
| private void Connect(Socket socket, EndPoint endPoint, CancellationToken cancellationToken) | ||
| { | ||
| var isSocketDisposed = false; | ||
| var callbackState = new OperationCallbackState<Socket>(socket); | ||
| using var timeoutCancellationTokenSource = new CancellationTokenSource(_settings.ConnectTimeout); | ||
| using var combinedCancellationTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken, timeoutCancellationTokenSource.Token); | ||
| using var cancellationSubscription = combinedCancellationTokenSource.Token.Register(DisposeSocket); | ||
| using var cancellationSubscription = combinedCancellationTokenSource.Token.Register(state => | ||
| { | ||
| var operationState = (OperationCallbackState<Socket>)state; | ||
| if (operationState.TryChangeStatusFromInProgress(OperationCallbackState<Socket>.OperationStatus.Interrupted)) | ||
| { | ||
| DisposeSocket(operationState.Subject); | ||
| } | ||
| }, callbackState); | ||
|
|
||
| try | ||
| { | ||
|
|
@@ -185,13 +194,14 @@ private void Connect(Socket socket, EndPoint endPoint, CancellationToken cancell | |
| #else | ||
| socket.Connect(endPoint); | ||
| #endif | ||
| if (!callbackState.TryChangeStatusFromInProgress(OperationCallbackState<Socket>.OperationStatus.Done)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add a unittest for this with mock socket? |
||
| { | ||
| throw new ObjectDisposedException(nameof(Socket)); | ||
| } | ||
| } | ||
| catch | ||
| { | ||
| if (!isSocketDisposed) | ||
| { | ||
| DisposeSocket(); | ||
| } | ||
| DisposeSocket(socket); | ||
|
|
||
| cancellationToken.ThrowIfCancellationRequested(); | ||
| if (timeoutCancellationTokenSource.IsCancellationRequested) | ||
|
|
@@ -202,9 +212,8 @@ private void Connect(Socket socket, EndPoint endPoint, CancellationToken cancell | |
| throw; | ||
| } | ||
|
|
||
| void DisposeSocket() | ||
| static void DisposeSocket(Socket socket) | ||
| { | ||
| isSocketDisposed = true; | ||
| try | ||
| { | ||
| socket.Dispose(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System.Threading; | ||
|
|
||
| namespace MongoDB.Driver.Core.Misc; | ||
|
|
||
| internal sealed class OperationCallbackState<T>(T subject) | ||
| { | ||
| private int _status = (int)OperationStatus.InProgress; | ||
|
|
||
| public OperationStatus Status => (OperationStatus)_status; | ||
| public T Subject => subject; | ||
| public bool TryChangeStatusFromInProgress(OperationStatus newState) => | ||
| Interlocked.CompareExchange(ref _status, (int)newState, (int)OperationStatus.InProgress) == (int)OperationStatus.InProgress; | ||
|
|
||
| public enum OperationStatus | ||
| { | ||
| InProgress = 0, | ||
| Done, | ||
| Interrupted, | ||
| } | ||
| } | ||
|
|
||
|
|
||
sanych-sun marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.