Skip to content

Conversation

@ajcvickers
Copy link
Collaborator

No description provided.

@ajcvickers ajcvickers requested a review from damieng January 19, 2026 12:24
@ajcvickers ajcvickers requested a review from a team as a code owner January 19, 2026 12:24
Copilot AI review requested due to automatic review settings January 19, 2026 12:24
@ajcvickers ajcvickers merged commit 89057b0 into main Jan 19, 2026
5 of 7 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables a failing encryption test that is experiencing issues only on Windows Latest in the CI environment. The test Encrypted_data_can_not_be_read_with_wrong_master_key validates that encrypted data cannot be decrypted using an incorrect master key.

Changes:

  • Added a Skip attribute to the Encrypted_data_can_not_be_read_with_wrong_master_key test with a reason indicating it fails on Windows Latest in CI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}

[EncryptionTheory]
[EncryptionTheory (Skip = "Failing only on Windows Latest in the C.I.")]
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no space between the attribute name and the opening parenthesis. The correct format is [EncryptionTheory(Skip = ...)] without a space before the opening parenthesis.

Suggested change
[EncryptionTheory (Skip = "Failing only on Windows Latest in the C.I.")]
[EncryptionTheory(Skip = "Failing only on Windows Latest in the C.I.")]

Copilot uses AI. Check for mistakes.
}

[EncryptionTheory]
[EncryptionTheory (Skip = "Failing only on Windows Latest in the C.I.")]
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The abbreviation "C.I." should be written as "CI" without periods. This is the standard way to write the abbreviation for Continuous Integration.

Suggested change
[EncryptionTheory (Skip = "Failing only on Windows Latest in the C.I.")]
[EncryptionTheory (Skip = "Failing only on Windows Latest in the CI.")]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants