Skip to content

Conversation

@ajcvickers
Copy link
Collaborator

No description provided.

@ajcvickers ajcvickers requested a review from damieng January 20, 2026 09:15
@ajcvickers ajcvickers requested a review from a team as a code owner January 20, 2026 09:15
Copilot AI review requested due to automatic review settings January 20, 2026 09:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a test attribute and corrects a spelling issue in the skip reason for an encryption test.

Changes:

  • Changed EncryptionTheory to Theory attribute on the Encrypted_data_can_not_be_read_with_wrong_master_key test
  • Corrected "C.I." to "CI" in the skip reason text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}

[EncryptionTheory (Skip = "Failing only on Windows Latest in the C.I.")]
[Theory(Skip = "Failing only on Windows Latest in the CI")]
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from EncryptionTheory to Theory removes the automatic skip logic that checks if the encryption library is present (defined at lines 210-216). With this change, the test will be skipped unconditionally even when the encryption library is available and the test could run successfully on non-Windows platforms. Consider using EncryptionTheory(Skip = "Failing only on Windows Latest in the CI") to preserve the encryption library check while still skipping on the problematic Windows CI environment.

Suggested change
[Theory(Skip = "Failing only on Windows Latest in the CI")]
[EncryptionTheory(Skip = "Failing only on Windows Latest in the CI")]

Copilot uses AI. Check for mistakes.
@ajcvickers ajcvickers merged commit 4fb0fdf into main Jan 20, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants