Skip to content

Commit a3e8c9c

Browse files
GODRIVER-3455 Remove unused EncodeValue methods
1 parent da49bdb commit a3e8c9c

File tree

4 files changed

+4
-47
lines changed

4 files changed

+4
-47
lines changed

bson/array_codec.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,6 @@ import (
1515
// arrayCodec is the Codec used for bsoncore.Array values.
1616
type arrayCodec struct{}
1717

18-
// EncodeValue is the ValueEncoder for bsoncore.Array values.
19-
func (ac *arrayCodec) EncodeValue(_ EncodeContext, vw ValueWriter, val any) error {
20-
arr, ok := val.(bsoncore.Array)
21-
if !ok {
22-
return ValueEncoderError{Name: "CoreArrayEncodeValue", Types: []reflect.Type{tCoreArray}, Received: reflect.ValueOf(val)}
23-
}
24-
25-
return copyArrayFromBytes(vw, arr)
26-
}
27-
2818
// DecodeValue is the ValueDecoder for bsoncore.Array values.
2919
func (ac *arrayCodec) DecodeValue(_ DecodeContext, vr ValueReader, val reflect.Value) error {
3020
if !val.CanSet() || val.Type() != tCoreArray {

bson/default_value_encoders_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1791,7 +1791,7 @@ func TestDefaultValueEncoders(t *testing.T) {
17911791
t.Run("EmptyInterfaceEncodeValue/nil", func(t *testing.T) {
17921792
val := reflect.New(tEmpty).Elem()
17931793
llvrw := new(valueReaderWriter)
1794-
err := (&emptyInterfaceCodec{}).EncodeValue(EncodeContext{Registry: newTestRegistry()}, llvrw, val)
1794+
err := emptyInterfaceValue(EncodeContext{Registry: newTestRegistry()}, llvrw, val)
17951795
noerr(t, err)
17961796
if llvrw.invoked != writeNull {
17971797
t.Errorf("Incorrect method called. got %v; want %v", llvrw.invoked, writeNull)
@@ -1802,10 +1802,10 @@ func TestDefaultValueEncoders(t *testing.T) {
18021802
val := reflect.New(tEmpty).Elem()
18031803
val.Set(reflect.ValueOf(int64(1234567890)))
18041804
llvrw := new(valueReaderWriter)
1805-
got := (&emptyInterfaceCodec{}).EncodeValue(EncodeContext{Registry: newTestRegistry()}, llvrw, val)
1805+
err := emptyInterfaceValue(EncodeContext{Registry: newTestRegistry()}, llvrw, val)
18061806
want := errNoEncoder{Type: tInt64}
1807-
if !assert.CompareErrors(got, want) {
1808-
t.Errorf("Did not receive expected error. got %v; want %v", got, want)
1807+
if !assert.CompareErrors(err, want) {
1808+
t.Errorf("Did not receive expected error. got %v; want %v", err, want)
18091809
}
18101810
})
18111811
}

bson/empty_interface_codec.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -17,28 +17,6 @@ type emptyInterfaceCodec struct {
1717
decodeBinaryAsSlice bool
1818
}
1919

20-
// Assert that emptyInterfaceCodec satisfies the typeDecoder interface, which allows it
21-
// to be used by collection type decoders (e.g. map, slice, etc) to set individual values in a
22-
// collection.
23-
var _ typeDecoder = &emptyInterfaceCodec{}
24-
25-
// EncodeValue is the ValueEncoderFunc for interface{}.
26-
func (eic *emptyInterfaceCodec) EncodeValue(ec EncodeContext, vw ValueWriter, val reflect.Value) error {
27-
if !val.IsValid() || val.Type() != tEmpty {
28-
return ValueEncoderError{Name: "EmptyInterfaceEncodeValue", Types: []reflect.Type{tEmpty}, Received: val}
29-
}
30-
31-
if val.IsNil() {
32-
return vw.WriteNull()
33-
}
34-
encoder, err := ec.LookupEncoder(val.Elem().Type())
35-
if err != nil {
36-
return err
37-
}
38-
39-
return encoder.EncodeValue(ec, vw, val.Elem())
40-
}
41-
4220
func (eic *emptyInterfaceCodec) getEmptyInterfaceDecodeType(dc DecodeContext, valueType Type) (reflect.Type, error) {
4321
isDocument := valueType == Type(0) || valueType == TypeEmbeddedDocument
4422
if isDocument {

bson/time_codec.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,3 @@ func (tc *timeCodec) DecodeValue(dc DecodeContext, vr ValueReader, val reflect.V
9797
val.Set(elem)
9898
return nil
9999
}
100-
101-
// EncodeValue is the ValueEncoderFunc for time.TIme.
102-
func (tc *timeCodec) EncodeValue(_ EncodeContext, vw ValueWriter, val any) error {
103-
timeVal, ok := val.(time.Time)
104-
if !ok {
105-
return ValueEncoderError{Name: "TimeEncodeValue", Types: []reflect.Type{tTime}, Received: reflect.ValueOf(val)}
106-
}
107-
108-
dt := NewDateTimeFromTime(timeVal)
109-
return vw.WriteDateTime(int64(dt))
110-
}

0 commit comments

Comments
 (0)