GODRIVER-3326 Add ObjectIDAsHexString to BSONOptions.
#1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change Report./v2/mongo/optionscompatible changesBSONOptions.ObjectIDAsHexString: added ./v2/x/mongo/driverincompatible changes##CursorOptions.MarshalValueEncoderFn: changed from func(io.Writer) (*./v2/bson.Encoder, error) to func(io.Writer) *./v2/bson.Encoder |
qingyang-hu
added
review-priority-normal
| }) | ||
| } | ||
|
|
||
| func TestGetDecoder(t *testing.T) { |
There was a problem hiding this comment.
Suggest running this test and subtests in parallel.
| } | ||
| } | ||
|
|
||
| func TestGetEncoder(t *testing.T) { |
There was a problem hiding this comment.
Suggest running this test and subtests in parallel.
prestonvasquez
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3326
Summary
ObjectIDAsHexStringtoBSONOptionsand enable it to set thebson.Decoder.TestGetDecoderandTestGetEncoderto guarantee:bson.Decoder/bson.Encoderconfig method has a corresponding field inBSONOptions.getDecoder()/getEncoder()calls the correspondingbson.Decoder/bson.Encoderconfig methods according toBSONOptionsfields.EncoderFn.Background & Motivation