GODRIVER-963 canonical parameter is not respected in UnmarshalExtJSON #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
matthewdale
reviewed
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-963
Summary
Background & Motivation
"The canonical parameter in UnmarshalExtJSON not forcing strictly canonical or non-canonical unmarshaling, but instead disabling unmarshaling non-canonical format when canonical=true. If canonical=false in UnmarshalExtJSON, it will unmarshal canonical or "relaxed" extended JSON."
Followed Matt's comment to rename canonical to canonicalOnly and update the documentation to describe the above behavior.