GODRIVER-2838 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
|
Noticed serverMonitoringMode.json still references sharded-replicaset, but it remains like that in mongodb/specifications as well, so I did not alter it for now. |
|
It appears mongodb/specifications@1a3b359#diff-ab30f6a6bc5cdfdb8afa50db7d76a5fd271db67949d066595b8bf56a806dcb94 from GODRIVER-2538 missed syncing |
prestonvasquez
approved these changes
Sep 24, 2024
| "id": "client", | ||
| "uriOptions": { | ||
| "timeoutMS": 50 | ||
| "timeoutMS": 250 |
There was a problem hiding this comment.
It's interesting that this was missed in #1009
|
drivers-pr-bot please backport to v1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2838
Summary
Synced spec tests affected by DRIVERS-2609 and DRIVERS-2675.
Background & Motivation