Skip to content

Conversation

matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented Oct 14, 2024

GODRIVER-3066

Summary

  • Move internal/integration/*_test.go files to the mongo package.
  • Resolve test file name conflicts by adding "_integ" to all test file names in package mongo_test.

Background & Motivation

The integration tests in internal/integration are perhaps better suited to live in the mongo package. This continues the work started in #1859

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the review-priority-low Low Priority PR for Review: within 3 business days label Oct 14, 2024
Copy link
Contributor

API Change Report

No changes found!

Copy link
Member

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@matthewdale matthewdale marked this pull request as draft October 14, 2024 23:59
@matthewdale matthewdale removed the request for review from prestonvasquez October 14, 2024 23:59
@matthewdale
Copy link
Collaborator Author

matthewdale commented Oct 15, 2024

The logical scope of this change is actually larger than just moving tests around. We should:

  • Factor out unified and legacy spec test "helper" and "runner" logic into separate internal packages
    • Optionally, move the relevant test runners into the same package so we don't have to export as much of the API.
  • Rename TestUnifiedSpecs to TestLegacySpec and move the unified and legacy spec test entrypoints into the mongo package.

For now, it doesn't seem worth making the partial version of that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-priority-low Low Priority PR for Review: within 3 business days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants