Skip to content

Conversation

matthewdale
Copy link
Collaborator

GODRIVER-3340

Summary

Bump github.com/klauspost/compress from 1.13.6 to 1.17.2

Background & Motivation

Resolves a goroutine/memory leak when using zstd compression.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added dependencies Pull requests that update a dependency file review-priority-low Low Priority PR for Review: within 3 business days labels Oct 16, 2024
@mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

@blink1073
Copy link
Member

Oh, buildcheck failed on 1.18:

[2024/10/15 22:26:57.984] # github.com/klauspost/compress/zstd
[2024/10/15 22:26:57.984] vendor/github.com/klauspost/compress/zstd/dict.go:479:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/10/15 22:26:57.984] vendor/github.com/klauspost/compress/zstd/dict.go:490:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/10/15 22:26:57.984] vendor/github.com/klauspost/compress/zstd/dict.go:491:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/10/15 22:26:57.984] vendor/github.com/klauspost/compress/zstd/dict.go:492:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/10/15 22:26:59.113] etc/compile_check.sh

@matthewdale
Copy link
Collaborator Author

Ugh, good catch! Looks like the Go 1.18 build check on master is not working correctly (it uses Go 1.22 🤦 ).

@matthewdale
Copy link
Collaborator Author

Closing because klauspost/[email protected] does not support Go 1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file review-priority-low Low Priority PR for Review: within 3 business days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants