Use a local Go 1.18 installation to check for minimum version support. #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
matthewdale
force-pushed
the
fix-go118-build
branch
2 times, most recently
from
46be763 to
7b00586
Compare
matthewdale
force-pushed
the
fix-go118-build
branch
from
7b00586 to
dcbe18f
Compare
matthewdale
added
review-priority-normal
blink1073
reviewed
Oct 18, 2024
blink1073
reviewed
Oct 23, 2024
blink1073
reviewed
Oct 23, 2024
blink1073
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
compile_check.shto use a "local" Go installation (i.e.go install golang.org/dl/go[ver]@latest) for checking the Go 1.18 build.buildTaskfile target to run all the build steps sequentially so the output is understandable.Background & Motivation
The
go1.18-buildtask currently doesn't actually use Go 1.18 to build. Theadd_to_pathinstruction is ineffective because the Taskfile is configured to load environment variables from a.envfile. Instead, we should use a "local" Go 1.18 installation so we don't have to worry about overriding PATH.