Complete pending CSOT reads in foreground #1873
Conversation
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change Report./v2/eventcompatible changesConnectionPendingReadDuration: added ./v2/x/mongo/driver/drivertestincompatible changes##(*ChannelConn).Read: changed from func(context.Context) ([]byte, error) to func(context.Context, ..../v2/x/mongo/driver/mnet.ReadOption) ([]byte, error) ./v2/x/mongo/driver/mnetincompatible changesNewConnection: changed from func(interface{ReadWriteCloser; Describer}) *Connection to func(interface{ReadWriteCloser; Describer}) *Connection compatible changesReadOption: added ./v2/x/mongo/driver/sessionincompatible changes##./v2/x/mongo/driver/mnet.ReadWriteCloser.Read: changed from func(context.Context) ([]byte, error) to func(context.Context, ..../v2/x/mongo/driver/mnet.ReadOption) ([]byte, error) ./v2/x/mongo/driver/topologyincompatible changes##(*Connection).Read: changed from func(context.Context) ([]byte, error) to func(context.Context, ..../v2/x/mongo/driver/mnet.ReadOption) ([]byte, error) compatible changesPendingReadTimeout: added |
…ez/mongo-go-driver into DRIVERS-2884-foreground-exp
| res, err = roundTrip(ctx, conn, *wm) | ||
|
|
||
| readOpts := []mnet.ReadOption{} | ||
| if maxTimeMS != 0 { |
There was a problem hiding this comment.
What about the case where a user provides maxTimeMs in the command function, such as tailable awaitData cursors? In that case we omit maxTimeMS, but we should still rely on the pending read behavior.
1 participant
Summary
Background & Motivation