Skip to content

Conversation

@matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented Jan 1, 2025

GODRIVER-3307

Summary

  • Use keyed structs for all MarshalValue test cases to make them easier to read.
  • Use only struct literals instead of functions to define the MarshalValue test cases.
  • Don't use Marshal when testing MarshalValue to prevent bugs in Marshal from masking bugs in MarshalValue.
  • Remove unnecessary subtest nesting in TestMarshalValue.

Background & Motivation

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the review-priority-low Low Priority PR for Review: within 3 business days label Jan 1, 2025
@mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

@matthewdale matthewdale force-pushed the godriver3307-refactor-test-marshal branch from e0ea3b6 to 702e571 Compare January 24, 2025 02:32
@matthewdale matthewdale marked this pull request as ready for review January 24, 2025 02:52
@matthewdale matthewdale merged commit f30efd2 into mongodb:master Feb 5, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-priority-low Low Priority PR for Review: within 3 business days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants