GODRIVER-3478 Use ExtJSON for BSON binary vector spec tests. #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
prestonvasquez
requested changes
Apr 2, 2025
bson/bson_binary_vector_spec_test.go
Outdated
| } | ||
|
|
||
| func convertSlice[T int8 | float32 | byte](s []interface{}) []T { | ||
| func convertSlice[T int8 | float32 | byte](t *testing.T, data []byte) []T { |
There was a problem hiding this comment.
Suggested change
| func convertSlice[T int8 | float32 | byte](t *testing.T, data []byte) []T { | |
| func convertSlice[T int8 | float32 | byte](t *testing.T, data []byte) []T { | |
| t.Helper() |
Alternatively, this method could be re-written to return an error.
bson/bson_binary_vector_spec_test.go
Outdated
Comment on lines
90
to
92
| if err != nil { | ||
| t.Fatalf("got %q while handling %s", err, string(data)) | ||
| } |
There was a problem hiding this comment.
Suggest using the require package
Suggested change
| if err != nil { | |
| t.Fatalf("got %q while handling %s", err, string(data)) | |
| } | |
| require.NoError(t, err) |
bson/bson_binary_vector_spec_test.go
Outdated
| } | ||
|
|
||
| func convertSlice[T int8 | float32 | byte](s []interface{}) []T { | ||
| func convertSlice[T int8 | float32 | byte](t *testing.T, data []byte) []T { |
There was a problem hiding this comment.
Should this function be renamed to decodeTestSlice / unmarshalTestSlice?
prestonvasquez
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3478
Summary
Use ExtJSON for BSON binary vector spec tests.
Background & Motivation
Sync mongodb/specifications@ccd72de