GODRIVER-3445 Use Git submodules for spec tests #2007
Conversation
…-testpath GODRIVER-3445 Refactor how spec test paths are built and update test dirs.
…ctest-path GODRIVER-3445 Make spectest.Path work for any caller.
…workflow GODRIVER-3445 Update specifications submodule weekly with dependabot.
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
prestonvasquez
changed the title
|
|
||
| // run a CRUD operation and verify errors and outcomes. | ||
| // the test description is needed to see determine if the test is an aggregate with $out | ||
| func runCrudOperation(mt *mtest.T, testDescription string, operation crudOperation, outcome crudOutcome) { |
There was a problem hiding this comment.
All additional code in retryable_writes_prose_test.go was copied from crud_spec_test.go, which was removed because it's redundant with the new CRUD unified spec tests.
matthewdale
force-pushed
the
GODRIVER-3445
branch
from
2c40309 to
285ab76
Compare
| // TODO: create new directory for mongocrypt | ||
| const resourcesDir = "../../../../testdata/mongocrypt" |
There was a problem hiding this comment.
Is this TODO still relevant?
| case "maxconnecting": | ||
| require.Equal(t, value, float64(cs.MaxConnecting)) | ||
| default: | ||
| fmt.Println(key) |
There was a problem hiding this comment.
Remove println.
| fmt.Println(key) |
| // Test case for all connection string spec tests. | ||
| func TestAuthSpec(t *testing.T) { | ||
| for _, file := range spectest.FindJSONFilesInDir(t, authTestsDir) { | ||
| fmt.Println("file", file) |
There was a problem hiding this comment.
Remove println.
| fmt.Println("file", file) |
| } | ||
|
|
||
| func runConnectionStringTest(t *testing.T, test connectionStringTest) { | ||
| if test.SkipReason != "" { |
There was a problem hiding this comment.
Can we also remove the SkipReason field from the connectionStringTest struct? As far as I can tell, the connection-string test spec don't include that field.
| params: | ||
| working_dir: "src/go.mongodb.org/mongo-driver" | ||
| script: | | ||
| git submodule update --init |
There was a problem hiding this comment.
Optional: Consider using the init-submodule task instead.
There was a problem hiding this comment.
This solution doesn't work for windows for some reason 🤷
There was a problem hiding this comment.
That's weird. Oh well, 🤷
2 participants
GODRIVER-3445
This PR suggested using git submodules to avoid manually syncing unified spec tests with the MongoDB specifications.
When using for the first time, users must initialize the submodule:
And then switching to branches that do not have the spec submodule: