-
Notifications
You must be signed in to change notification settings - Fork 918
GODRIVER-3037 Support internal-only options. #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright (C) MongoDB, Inc. 2025-present. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. You may obtain | ||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| package options | ||
|
|
||
| // Options stores internal options. | ||
| type Options struct { | ||
| values map[string]any | ||
| } | ||
|
|
||
| // WithValue sets an option value with the associated key. | ||
| func WithValue(opts Options, key string, option any) Options { | ||
| if opts.values == nil { | ||
| opts.values = make(map[string]any) | ||
| } | ||
| opts.values[key] = option | ||
| return opts | ||
| } | ||
|
|
||
| // Value returns the value associated with the options for key. | ||
| func Value(opts Options, key string) any { | ||
| if opts.values == nil { | ||
| return nil | ||
| } | ||
| if val, ok := opts.values[key]; ok { | ||
| return val | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // Equal compares two Options instances for equality. | ||
| func Equal(opts1, opts2 Options) bool { | ||
| if len(opts1.values) != len(opts2.values) { | ||
| return false | ||
| } | ||
| for key, val1 := range opts1.values { | ||
| if val2, ok := opts2.values[key]; !ok || val1 != val2 { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // Copyright (C) MongoDB, Inc. 2025-present. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. You may obtain | ||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| package options | ||
|
||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "go.mongodb.org/mongo-driver/v2/mongo/options" | ||
| "go.mongodb.org/mongo-driver/v2/x/mongo/driver" | ||
| ) | ||
|
|
||
| // SetInternalClientOptions sets internal options for ClientOptions. | ||
| // | ||
| // Deprecated: This function is for internal use only. It may be changed or removed in any release. | ||
| func SetInternalClientOptions(opts *options.ClientOptions, key string, option any) error { | ||
qingyang-hu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const typeErr = "unexpected type for %s" | ||
| switch key { | ||
| case "crypt": | ||
| c, ok := option.(driver.Crypt) | ||
| if !ok { | ||
| return fmt.Errorf(typeErr, key) | ||
| } | ||
| opts.Crypt = c | ||
| case "deployment": | ||
| d, ok := option.(driver.Deployment) | ||
| if !ok { | ||
| return fmt.Errorf(typeErr, key) | ||
| } | ||
| opts.Deployment = d | ||
| default: | ||
| return fmt.Errorf("unsupported option: %s", key) | ||
| } | ||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // Copyright (C) MongoDB, Inc. 2025-present. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. You may obtain | ||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| package options | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "go.mongodb.org/mongo-driver/v2/internal/require" | ||
| "go.mongodb.org/mongo-driver/v2/mongo/options" | ||
| "go.mongodb.org/mongo-driver/v2/x/mongo/driver" | ||
| "go.mongodb.org/mongo-driver/v2/x/mongo/driver/drivertest" | ||
| ) | ||
|
|
||
| func TestSetInternalClientOptions(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run("set crypt", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| c := driver.NewCrypt(&driver.CryptOptions{}) | ||
| opts := options.Client() | ||
| err := SetInternalClientOptions(opts, "crypt", c) | ||
| require.NoError(t, err, "error setting crypt: %v", err) | ||
| require.Equal(t, c, opts.Crypt, "expected %v, got %v", c, opts.Crypt) | ||
| }) | ||
|
|
||
| t.Run("set crypt - wrong type", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| opts := options.Client() | ||
| err := SetInternalClientOptions(opts, "crypt", &drivertest.MockDeployment{}) | ||
| require.EqualError(t, err, "unexpected type for crypt") | ||
| }) | ||
|
|
||
| t.Run("set deployment", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| d := &drivertest.MockDeployment{} | ||
| opts := options.Client() | ||
| err := SetInternalClientOptions(opts, "deployment", d) | ||
| require.NoError(t, err, "error setting deployment: %v", err) | ||
| require.Equal(t, d, opts.Deployment, "expected %v, got %v", d, opts.Deployment) | ||
| }) | ||
|
|
||
| t.Run("set deployment - wrong type", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| opts := options.Client() | ||
| err := SetInternalClientOptions(opts, "deployment", driver.NewCrypt(&driver.CryptOptions{})) | ||
| require.EqualError(t, err, "unexpected type for deployment") | ||
| }) | ||
|
|
||
| t.Run("set unsupported option", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| opts := options.Client() | ||
| err := SetInternalClientOptions(opts, "unsupported", "unsupported") | ||
| require.EqualError(t, err, "unsupported option: unsupported") | ||
| }) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.