GODRIVER-3429 Revert internal-only "AuthenticateToAnything". #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
qingyang-hu
force-pushed
the
godriver3429
branch
from
42b3754 to
81b9815
Compare
API Change Report./v2/mongo/optionsincompatible changes##ClientOptions.Custom: changed from ./v2/internal/options.Options to ./v2/internal/optionsutil.Options |
qingyang-hu
force-pushed
the
godriver3429
branch
from
5e7cc5f to
5ad38c2
Compare
qingyang-hu
force-pushed
the
godriver3429
branch
from
5ad38c2 to
16f8f28
Compare
prestonvasquez
requested changes
May 5, 2025
x/mongo/driver/xoptions/options.go
Outdated
| case "authenticateToAnything": | ||
| b, ok := option.(bool) | ||
| if !ok { | ||
| return fmt.Errorf(typeErr, key) |
There was a problem hiding this comment.
Can we update these errors to describe the type that we want? Possible using some kind of composing function:
typeErrFuc := func() string {
return fmt.Sprintf("unexecpted type for %q, wanted %T, got %T", key, option, option)
}
x/mongo/driver/xoptions/options.go
Outdated
| import ( | ||
| "fmt" | ||
|
|
||
| internalOptions "go.mongodb.org/mongo-driver/v2/internal/options" |
There was a problem hiding this comment.
Should we rename the internal/options package to internal/optionsutil? That seems to follow the existing pattern. Then we can avoid aliasing imports.
prestonvasquez
previously approved these changes
May 9, 2025
x/mongo/driver/auth/auth_test.go
Outdated
|
|
||
| cases := []struct { | ||
| name string | ||
| needToPerform bool |
There was a problem hiding this comment.
[optional] Suggest calling this bool authenticateToAnything.
x/mongo/driver/auth/auth_test.go
Outdated
| { | ||
| name: "positive", | ||
| needToPerform: true, | ||
| assert: func(t *testing.T, err error) { |
There was a problem hiding this comment.
[optional] Suggest renaming this to require.
| cases := []struct { | ||
| name string | ||
| set func(*options.ClientOptions) error | ||
| assert func(*testing.T, error) |
There was a problem hiding this comment.
[Optional] Suggest renaming this to require.
prestonvasquez
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3429
Summary
PerformAuthenticationinHandshakeOptions.Background & Motivation