GODRIVER-3560 Use lambda-specific arn for FaaS #2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
vbabanin
reviewed
Jun 9, 2025
| setup_group: | ||
| - func: fetch-source | ||
| - func: prepare-resources | ||
| - func: assume-test-secrets-ec2-role |
There was a problem hiding this comment.
[nit] Just to clarify - is assume-test-secrets-ec2-roleremoved to bump the duration to 3600? It is possible to define a variable for a function which is treated as expansions in the commands, so the duration could be parameterized in assume-test-secrets-ec2-role. Feel free to resolve - it is [nit].
There was a problem hiding this comment.
We have a global 3600ms exec_timeout_secs. The issue was not extending the expansion with the env variables set by assuming the role. I will re-add this step.
vbabanin
approved these changes
Jun 9, 2025
vbabanin
approved these changes
Jun 10, 2025
prestonvasquez
commented
Jun 10, 2025
| Variables: | ||
| MONGODB_URI: !Ref MongoDbUri | ||
|
|
||
| ApplicationResourceGroup: |
There was a problem hiding this comment.
Resolves GODRIVER-3557.
This was referenced Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3560
Summary
Extend env variables from assuming role.
Background & Motivation
Evergreen CI for FaaS isn't tearing down the resulting Atlas cluster.