Prevent integration tests from running when testing with -short #2116
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
qingyang-hu
reviewed
Jun 27, 2025
| // ConnString gets the globally configured connection string. | ||
| func ConnString(t *testing.T) *connstring.ConnString { | ||
| if testing.Short() { | ||
| t.Skip("skipping integration test in short mode") |
There was a problem hiding this comment.
It's a little strange to skip the tests from a helper function. Is it possible to skip from TestXXX()?
There was a problem hiding this comment.
The goal is to skip any tests that seem to be integration tests when using the -short test flag. We do something similar in mtest.New, which prevents us from having to add the if testing.Short() check in all the tests that use mtest.
We could add the if testing.Short() check to all tests individually, but that has been error-prone. Ideally all integration tests would use mtest, but tests in the mongo package can't import mtest, so integration tests are stuck using integtest.ConnString.
qingyang-hu
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
integtest.ConnStringif running with-short.TestServerHeartbeatTimeouttest if running with-shortbecause it's an integration test.Background & Motivation
This should also fix the "Docker Runner Test" task.