-
Notifications
You must be signed in to change notification settings - Fork 918
GODRIVER-3102: Perf comparison #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
API Change ReportNo changes found! |
62e5e7c
to
8cc29fd
Compare
…nto GODRIVER-3102-3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
P.S. If getting the comment to post in Github is going to take significantly more time, I recommend merging this PR without that functionality and adding it in a subsequent PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Co-authored-by: Matt Dale <[email protected]>
* master: (65 commits) Replace all uses of 'interface{}' with 'any' in the bson package. (#2138) GODRIVER-3473 Short-cicruit cursor.next() on invalid timeouts (#2135) GODRIVER-3622 Automatically retry some test tasks. (#2147) Replace all uses of 'interface{}' with 'any' in the repo docs. (#2142) GODRIVER-3102: Perf comparison (#2134) GODRIVER-3587 Use raw bytes in valueReader (#2120) Replace all uses of 'interface{}' with 'any' in the internal/ packages. (#2140) Replace all uses of 'interface{}' with 'any' in the x/ packages. (#2137) GODRIVER-2016 Unskip all Transactions unified spec tests. (#2132) GODRIVER-2540 Run govulncheck in CI builds. (#2136) GODRIVER-3549 Update Client BulkWrite prose tests. (#2131) Add guidelines for contributing features to the Go Driver (#2125) Bump alcaeus/automatic-merge-up-action from 1.0.0 to 1.0.1 in the actions group (#2126) Add wrappedMsgOnly to mongo.MarshalError and mongo.MongocryptError. Bump testdata/specifications from `db69351` to `6689929` fix wiremessage oob in case of intmin (#2076) GODRIVER-3399: PoolClearedError should have TransientTransactionError label appended to it (#2114) PR feedback. Prevent integration tests from running when testing with -short Skip AWS Test if no URI (#2102) ...
GODRIVER-3102
Summary
After perf task is run, a perf comparison between the mainline benchmarks and the patch benchmarks is now made. This comparison calculates for h-score, z-score, and % change from the latest mainline stable region, and outputs the specific benchmarks that have a 95% confidence level of change (ie. where |z-score| < 1.96). Ultimately will be posted as a PR comment (but currently just outputs in Evergreen).
To run locally,
Background & Motivation
Have a better idea of how commits will affect performance before being merged into the mainline branch, more proactive than current method.