Skip to content

Conversation

zhouselena
Copy link
Contributor

@zhouselena zhouselena commented Jul 21, 2025

GODRIVER-3102

Summary

After perf task is run, a perf comparison between the mainline benchmarks and the patch benchmarks is now made. This comparison calculates for h-score, z-score, and % change from the latest mainline stable region, and outputs the specific benchmarks that have a 95% confidence level of change (ie. where |z-score| < 1.96). Ultimately will be posted as a PR comment (but currently just outputs in Evergreen).

To run locally,

perf_uri_private_endpoint="<endpoint>" VERSION_ID="<version>" sh etc/perf-pr-comment.sh

Background & Motivation

Have a better idea of how commits will affect performance before being merged into the mainline branch, more proactive than current method.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added dependencies Pull requests that update a dependency file review-priority-low Low Priority PR for Review: within 3 business days labels Jul 21, 2025
@mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

@zhouselena zhouselena marked this pull request as ready for review July 22, 2025 17:48
@zhouselena zhouselena requested a review from a team as a code owner July 22, 2025 17:48
matthewdale
matthewdale previously approved these changes Jul 25, 2025
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

P.S. If getting the comment to post in Github is going to take significantly more time, I recommend merging this PR without that functionality and adding it in a subsequent PR.

qingyang-hu
qingyang-hu previously approved these changes Jul 25, 2025
prestonvasquez
prestonvasquez previously approved these changes Jul 28, 2025
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@zhouselena zhouselena merged commit 0c9c840 into mongodb:master Jul 29, 2025
29 of 34 checks passed
prestonvasquez pushed a commit to prestonvasquez/mongo-go-driver that referenced this pull request Jul 31, 2025
alcaeus added a commit that referenced this pull request Aug 5, 2025
* master: (65 commits)
  Replace all uses of 'interface{}' with 'any' in the bson package. (#2138)
  GODRIVER-3473 Short-cicruit cursor.next() on invalid timeouts (#2135)
  GODRIVER-3622 Automatically retry some test tasks. (#2147)
  Replace all uses of 'interface{}' with 'any' in the repo docs. (#2142)
  GODRIVER-3102: Perf comparison (#2134)
  GODRIVER-3587 Use raw bytes in valueReader (#2120)
  Replace all uses of 'interface{}' with 'any' in the internal/ packages. (#2140)
  Replace all uses of 'interface{}' with 'any' in the x/ packages. (#2137)
  GODRIVER-2016 Unskip all Transactions unified spec tests. (#2132)
  GODRIVER-2540 Run govulncheck in CI builds. (#2136)
  GODRIVER-3549 Update Client BulkWrite prose tests. (#2131)
  Add guidelines for contributing features to the Go Driver (#2125)
  Bump alcaeus/automatic-merge-up-action from 1.0.0 to 1.0.1 in the actions group (#2126)
  Add wrappedMsgOnly to mongo.MarshalError and mongo.MongocryptError.
  Bump testdata/specifications from `db69351` to `6689929`
  fix wiremessage oob in case of intmin (#2076)
  GODRIVER-3399: PoolClearedError should have TransientTransactionError label appended to it (#2114)
  PR feedback.
  Prevent integration tests from running when testing with -short
  Skip AWS Test if no URI (#2102)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file review-priority-low Low Priority PR for Review: within 3 business days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants