GODRIVER-3288 Stop gossiping $clusterTime on SDAM commands.

[qingyang-hu]

GODRIVER-3288

Summary

Stop gossiping $clusterTime on SDAM commands.

Background & Motivation

[mongodb-drivers-pr-bot]

API Change Report

No changes found!

[Copilot]

Pull Request Overview

This PR removes cluster clock gossiping from Server Discovery and Monitoring (SDAM) commands, specifically the "hello" command used for heartbeats and initial server discovery. The change ensures that $clusterTime is not included in SDAM operations to comply with MongoDB driver specifications.

• Removed cluster clock parameter from Hello operation constructors
• Added null checks to prevent cluster time operations when no clock is provided
• Added integration test to verify SDAM commands no longer gossip $clusterTime

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
x/mongo/driver/topology/topology_options.go	Removed cluster clock from Hello operation configuration
x/mongo/driver/topology/server.go	Removed cluster clock from heartbeat Hello operations
x/mongo/driver/operation/hello.go	Removed ClusterClock method and field from Hello struct
x/mongo/driver/operation.go	Added null checks for cluster clock operations
x/mongo/driver/auth/auth.go	Removed cluster clock from authentication Hello operations
internal/integration/sessions_test.go	Added test to verify SDAM commands don't gossip cluster time
internal/integration/mtest/mongotest.go	Added null check before client disconnect

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[prestonvasquez]

IIUC we still want to gossip cluster times when establishing connections.

[prestonvasquez]

Do we need this block? Wouldn't op.updateClusterTimes(res) be a no-op if op.Click == nil for hello commands?

[qingyang-hu]

We need to stop updating the cluster time in session too, so L1709 in addClusterTime() will not append a “$clusterTime”.

[prestonvasquez]

Suggest buffering these channels and adding a wait function:

wait := func(mt *mtest.T, ch <-chan struct{}, label string) {
	mt.Helper()

	select {
	case <-ch:
	case <-time.After(5 * time.Second):
		mt.Fatalf("timed out waiting for %s", label)
	}
}

wait(mt, heartbeatStarted, "heartbeat started")
wait(mt, heartbeatSucceeded, "heartbeat succeeded")