Use a pinned Go version for golangci-lint. #2151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
etc/golangci-lint.sh
frommaster
, which uses a pinned Go version for runninggolangci-lint
.test.yml
Github workflow frommaster
.Background & Motivation
The
golangci-lint
linter uses the local Go installation discovered in GOROOT and requires a specific range of Go versions to work correctly. If the local Go installation and thegolangci-lint
version get out-of-sync, the linters can print confusing error messages likeIn
master
, we added a script with #1826 that pins a specific version of Go when runninggolangci-lint
. Use that same script here.