Skip to content

Update default review priority tag #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alcaeus merged 1 commit into from
Aug 8, 2025
Merged

Update default review priority tag #2157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
priority-3-low:
review-priority-normal:
Copy link
Collaborator

@matthewdale matthewdale Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the default priority to be normal or low?

Copy link
Member Author

@alcaeus alcaeus Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to have normal as the default priority, with low and urgent being explicit choices:

  • review-priority-low - not time sensitive; review within 3 business days. Use for non-prioritized changes, e.g. build system changes that aren't blocking anyone
  • review-priority-normal (default) - aim to review within 24 hours, ideally on same day if pull request comes in before lunch
  • review-priority-urgent - urgent; review immediately. Only use after prior coordination. Nits and non-blocking review comments should be deferred to a follow-up pull request for an expedited merge.

- changed-files:
- any-glob-to-any-file: '*'

Expand Down
Loading