Retry Markdown link checks on HTTP 429 (v1) #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
added
review-priority-urgent
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry functionality to the markdown link checker to handle HTTP 429 (Too Many Requests) responses, specifically addressing failures with the http://reneefrench.blogspot.com/ site that frequently returns this status code during pre-commit checks.
- Added the
-rargument to enable automatic retrying on HTTP 429 responses - Included explanatory comment documenting the purpose of the retry flag
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
matthewdale
requested review from
prestonvasquez
and removed request for
qingyang-hu
prestonvasquez
approved these changes
Sep 3, 2025
API Change ReportNo changes found! |
This was referenced Sep 3, 2025
prestonvasquez
pushed a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Sep 4, 2025
This was referenced Sep 5, 2025
alcaeus
added a commit
that referenced
this pull request
Sep 22, 2025
* release/1.17: Retry Markdown link checks on HTTP 429 (v1) (#2186)
alcaeus
added a commit
that referenced
this pull request
Sep 22, 2025
* release/1.17: GODRIVER-3612 Add an internal-only NewSessionWithLSID API (v1) (#2183) Consider HTTP 429 a succcessful response in the Markdown link check. (#2191) Pin drivers-evergreen-tools to rev 98f6b0e in v1. (#2184) Retry Markdown link checks on HTTP 429 (v1) (#2186)
This was referenced Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Retry Markdown link checks when the endpoint responds with HTTP 429.
Background & Motivation
The http://reneefrench.blogspot.com/ site returns HTTP 429 frequently, leading to failed pre-commit checks when run in the Github Actions runners. The markdown-link-check tool supports retrying after an HTTP 429, automatically waiting until the time specified by the "retry-after" HTTP header. See the usage docs for details.
See previous PR #2181