Skip to content

GODRIVER-3648 Make server selection block on topology updates. #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

GODRIVER-3648 Make server selection block on topology updates. #2211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
768bf6d
GODRIVER-3648 Make server selection block on topology updates.
matthewdale Sep 26, 2025
de38ea6
Add a test to ensure selectServerFromSubscription isn't a busy wait.
matthewdale Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion x/mongo/driver/topology/topology.go
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test case for the change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it would be a good idea to add a test. I'll try to find a sensible assertion we can make to check that it doesn't enter a busy wait.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test that catches the busy-wait case.

Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,6 @@ func (t *Topology) selectServerFromSubscription(
case <-ctx.Done():
return nil, ServerSelectionError{Wrapped: ctx.Err(), Desc: current}
case current = <-subscriptionCh:
default:
}

suitable, err := t.selectServerFromDescription(current, srvSelector)
Expand Down
Loading