Skip to content

Conversation

ggyuchive
Copy link
Contributor

Summary

GODRIVER-3675

The file internal/decinal128/decinal128.go has a typo in its name (decinal instead of decimal).
This change renames it to decimal128.go for correctness and consistency with the package name.

Background & Motivation

@ggyuchive ggyuchive requested a review from a team as a code owner October 8, 2025 09:20
@ggyuchive ggyuchive requested a review from qingyang-hu October 8, 2025 09:20
@ggyuchive ggyuchive changed the title GODRIVER-3675 Rename internal/decimal/decinal128.go to decimal128.go GODRIVER-3675 Rename internal/decimal/decinal128.go to decimal128.go Oct 8, 2025
@matthewdale matthewdale added the review-priority-low Low Priority PR for Review: within 3 business days label Oct 13, 2025
Copy link
Contributor

🧪 Performance Results

Commit SHA: 1844f4c

The following benchmark tests for version 68e62ccfb1a26200071e91f2 had statistically significant changes (i.e., |z-score| > 1.96):

Benchmark Measurement % Change Patch Value Stable Region H-Score Z-Score
BenchmarkMultiFindMany ops_per_second_min 104.8569 51403.3104 Avg: 25092.2955
Med: 25519.4619
Stdev: 12497.5558
0.7483 2.1053
BenchmarkBSONDeepDocumentEncoding ops_per_second_min -96.2201 126.7163 Avg: 3352.4013
Med: 3344.4369
Stdev: 493.5010
0.9184 -6.5363
BenchmarkBSONFullDocumentDecoding total_bytes_allocated 14.3199 408021664.0000 Avg: 356912148.4944
Med: 360189992.0000
Stdev: 20938052.5174
0.8231 2.4410
BenchmarkBSONFlatDocumentEncoding total_mem_allocs 12.2467 259867.0000 Avg: 231514.2105
Med: 231840.5000
Stdev: 7157.4552
0.8654 3.9613
BenchmarkBSONFullDocumentDecoding total_mem_allocs 12.1773 9862446.0000 Avg: 8791840.5714
Med: 8807261.0000
Stdev: 312199.3505
0.8588 3.4292
BenchmarkBSONFlatDocumentEncoding total_bytes_allocated 12.1441 537597880.0000 Avg: 479381340.2105
Med: 480070996.0000
Stdev: 14736942.6167
0.8651 3.9504
BenchmarkBSONFlatDocumentEncoding ns_per_op -10.1742 14028.0000 Avg: 15616.8947
Med: 15599.5000
Stdev: 452.6500
0.8458 -3.5102
BenchmarkBSONFullDocumentEncoding total_bytes_allocated 9.0248 264984192.0000 Avg: 243049363.0175
Med: 242699256.0000
Stdev: 5247183.0845
0.8780 4.1803
BenchmarkMultiInsertSmallDocument ns_per_op -6.0078 6203.0000 Avg: 6599.4821
Med: 6592.0000
Stdev: 169.5139
0.7725 -2.3389
BenchmarkBSONDeepDocumentEncoding total_time_seconds 2.1149 1.2201 Avg: 1.1948
Med: 1.1946
Stdev: 0.0074
0.8394 3.4000
BenchmarkBSONFullDocumentEncoding ns_per_op -1.1739 23292.0000 Avg: 23568.6667
Med: 23572.0000
Stdev: 15.2753
0.9759 -18.1121
BenchmarkSmallDocInsertOne allocated_bytes_per_op -0.3695 5638.0000 Avg: 5658.9091
Med: 5660.0000
Stdev: 6.3951
0.8336 -3.2695
BenchmarkBSONFullDocumentDecoding allocated_bytes_per_op -0.0139 25320.0000 Avg: 25323.5306
Med: 25324.0000
Stdev: 1.1920
0.8308 -2.9619

For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch.

Copy link
Contributor

API Change Report

No changes found!

Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggyuchive, I really appreciate your contribution to the MongoDB Go Driver! This PR looks good to me!

@qingyang-hu qingyang-hu enabled auto-merge (squash) October 13, 2025 20:06
@qingyang-hu qingyang-hu merged commit f01f780 into mongodb:master Oct 14, 2025
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-priority-low Low Priority PR for Review: within 3 business days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants