CSOT refactoring #1781
Draft
CSOT refactoring #1781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make TimeoutContext immutable.
# Conflicts: # driver-core/src/main/com/mongodb/internal/connection/OperationContext.java # driver-core/src/main/com/mongodb/internal/operation/AggregateOperation.java # driver-core/src/main/com/mongodb/internal/operation/AggregateOperationImpl.java # driver-core/src/main/com/mongodb/internal/operation/AggregateToCollectionOperation.java # driver-core/src/main/com/mongodb/internal/operation/BaseFindAndModifyOperation.java # driver-core/src/main/com/mongodb/internal/operation/ChangeStreamOperation.java # driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java # driver-core/src/main/com/mongodb/internal/operation/CommandReadOperation.java # driver-core/src/main/com/mongodb/internal/operation/CountDocumentsOperation.java # driver-core/src/main/com/mongodb/internal/operation/CountOperation.java # driver-core/src/main/com/mongodb/internal/operation/CreateCollectionOperation.java # driver-core/src/main/com/mongodb/internal/operation/CreateIndexesOperation.java # driver-core/src/main/com/mongodb/internal/operation/CreateViewOperation.java # driver-core/src/main/com/mongodb/internal/operation/DistinctOperation.java # driver-core/src/main/com/mongodb/internal/operation/DropCollectionOperation.java # driver-core/src/main/com/mongodb/internal/operation/DropDatabaseOperation.java # driver-core/src/main/com/mongodb/internal/operation/DropIndexOperation.java # driver-core/src/main/com/mongodb/internal/operation/EstimatedDocumentCountOperation.java # driver-core/src/main/com/mongodb/internal/operation/FindOperation.java # driver-core/src/main/com/mongodb/internal/operation/ListCollectionsOperation.java # driver-core/src/main/com/mongodb/internal/operation/ListDatabasesOperation.java # driver-core/src/main/com/mongodb/internal/operation/ListIndexesOperation.java # driver-core/src/main/com/mongodb/internal/operation/ListSearchIndexesOperation.java # driver-core/src/main/com/mongodb/internal/operation/MapReduceToCollectionOperation.java # driver-core/src/main/com/mongodb/internal/operation/MapReduceWithInlineResultsOperation.java # driver-core/src/main/com/mongodb/internal/operation/MixedBulkWriteOperation.java # driver-core/src/main/com/mongodb/internal/operation/ReadOperation.java # driver-core/src/main/com/mongodb/internal/operation/ReadOperationCursor.java # driver-core/src/main/com/mongodb/internal/operation/ReadOperationMapReduceCursor.java # driver-core/src/main/com/mongodb/internal/operation/RenameCollectionOperation.java # driver-core/src/main/com/mongodb/internal/operation/WriteOperation.java # driver-core/src/test/functional/com/mongodb/ClusterFixture.java # driver-core/src/test/functional/com/mongodb/OperationFunctionalSpecification.groovy # driver-core/src/test/unit/com/mongodb/internal/operation/OperationUnitSpecification.groovy # driver-legacy/src/main/com/mongodb/LegacyMixedBulkWriteOperation.java # driver-legacy/src/main/com/mongodb/MongoClient.java # driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/MapReducePublisherImpl.java # driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/OperationExecutorImpl.java # driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/VoidReadOperationThenCursorReadOperation.java # driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/VoidWriteOperationThenCursorReadOperation.java # driver-sync/src/main/com/mongodb/client/internal/MapReduceIterableImpl.java # driver-sync/src/main/com/mongodb/client/internal/MongoClusterImpl.java
vbabanin
commented
Aug 10, 2025
| @@ -114,7 +110,8 @@ private ClusterBindingConnectionSource(final ServerTuple serverTuple, final Read | |||
| this.server = serverTuple.getServer(); | |||
| this.serverDescription = serverTuple.getServerDescription(); | |||
| this.appliedReadPreference = appliedReadPreference; | |||
| operationContext.getTimeoutContext().minRoundTripTimeMS(NANOSECONDS.toMillis(serverDescription.getMinRoundTripTimeNanos())); | |||
There was a problem hiding this comment.
Previously, TimeoutContext was mutable, and we would set minRoundTripTime on it once a connection source (i.e., server) was selected. Now, this logic has been moved into SyncOperationHelper:
- In withReadConnectionSource
- And in withSuppliedResource
The reasoning is that once a server is selected, we know the round-trip time and can propagate a modified OperationContext to getConnection. This method either retrieves a connection from the pool or establishes a new one, and then passes it to the operation’s callback.
Note: minRoundTripTime is used when calculating the maxTimeMS value appended to a command in CommandMessage.
The same change has been applied to the async counterpart in AsyncOperationHelper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.