Skip to content

Remove assertion for verbose result #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+272 −27
Open

Remove assertion for verbose result #1835

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
54930e0
Remove assertion.
vbabanin Nov 1, 2025
11ff53a
Add TODOs.
vbabanin Nov 12, 2025
307f498
Add tests,
vbabanin Nov 13, 2025
ab5c67f
Merge branch 'main' into assertion-removal
vbabanin Nov 13, 2025
46b3513
Update driver-core/src/test/unit/com/mongodb/internal/operation/Clien…
vbabanin Nov 13, 2025
a0b73ba
Merge branch 'main' into assertion-removal
rozza Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,8 +774,11 @@ ClientBulkWriteResult build(@Nullable final MongoException topLevelError, final
for (BsonDocument individualOperationResponse : response.getCursorExhaust()) {
int individualOperationIndexInBatch = individualOperationResponse.getInt32("idx").getValue();
int writeModelIndex = batchStartModelIndex + individualOperationIndexInBatch;
if (individualOperationResponse.getNumber("ok").intValue() == 1) {
assertTrue(verboseResultsSetting);
if (individualOperationResponse.getNumber("ok").intValue() == 1 && verboseResultsSetting) {
// Note: Previously, assertTrue(verboseResultsSetting) was used here because the server was not supposed
// to return successful operation results in the cursor when verboseResultsSetting is false.
// Due to server bug SERVER-113344, these unexpected results must be ignored until we stop supporting server
// versions with this bug. When that happens, restore assertTrue(verboseResultsSetting) here.
Copy link
Member

@stIncMale stIncMale Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave a TODO-<JAVA ticket ID> tag here, and create a corresponding ticket, which is linked as "blocked by" / "depends on" (not sure what relations we have) to the aforementioned server ticket.

Copy link
Member

@rozza rozza Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have to keep this code for some time (years) - while we wait for servers to be updated.

Copy link
Member Author

@vbabanin vbabanin Nov 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a TODO-JAVA-6002 tag and created a follow-up ticket to restore the assertion.

I linked it to the server ticket as blocked by. As @rozza mentioned, even after the server fix lands it may not be backported to 8.x, so we’ll likely re-enable the assertion once our minimum supported server version includes the fix (or gate it conditionally on server version).

AbstractClientNamespacedWriteModel writeModel = getNamespacedModel(models, writeModelIndex);
if (writeModel instanceof ConcreteClientNamespacedInsertOneModel) {
insertResults.put(
Expand Down