PHPC-410: zval_to_bson() should throw on non-Serializable Type objects

Author: jmikola

src/bson.c

@@ -805,6 +805,10 @@ PHONGO_API void zval_to_bson(zval *data, php_phongo_bson_flags_t flags, bson_t *
 					}
 				}
 
+				break;
+			} else if (instanceof_function(Z_OBJCE_P(data), php_phongo_type_ce TSRMLS_CC)) {
+				phongo_throw_exception(PHONGO_ERROR_UNEXPECTED_VALUE TSRMLS_CC, "%s cannot be serialized as a root element", Z_OBJCE_P(data)->name);
+
 				break;
 			}
 			/* break intentionally omitted */

tests/bson/bson-fromPHP_error-003.phpt

@@ -0,0 +1,54 @@
+--TEST--
+BSON\fromPHP(): Encoding non-Serializable Type objects as a root element
+--INI--
+date.timezone=America/Los_Angeles
+--SKIPIF--
+<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
+--FILE--
+<?php
+use MongoDB\BSON as BSON;
+
+require_once __DIR__ . "/../utils/basic.inc";
+
+class UnknownType implements BSON\Type {}
+
+$tests = array(
+    new UnknownType,
+    new BSON\Binary('foobar', BSON\Binary::TYPE_GENERIC),
+    new BSON\Javascript('function foo(bar) {var baz = bar; var bar = foo; return bar; }'),
+    new BSON\MinKey,
+    new BSON\MaxKey,
+    new BSON\ObjectId,
+    new BSON\Regex('regexp', 'i'),
+    new BSON\Timestamp(1234, 5678),
+    new BSON\UTCDateTime('1416445411987'),
+);
+
+foreach ($tests as $document) {
+    echo throws(function() use ($document) {
+        fromPHP($document);
+    }, 'MongoDB\Driver\Exception\UnexpectedValueException'), "\n";}
+
+?>
+===DONE===
+<?php exit(0); ?>
+--EXPECTF--
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+UnknownType cannot be serialized as a root element
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+%S\BSON\Binary cannot be serialized as a root element
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+%S\BSON\Javascript cannot be serialized as a root element
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+%S\BSON\MinKey cannot be serialized as a root element
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+%S\BSON\MaxKey cannot be serialized as a root element
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+%S\BSON\ObjectID cannot be serialized as a root element
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+%S\BSON\Regex cannot be serialized as a root element
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+%S\BSON\Timestamp cannot be serialized as a root element
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+%S\BSON\UTCDateTime cannot be serialized as a root element
+===DONE===