Skip to content

Commit d6b2fd6

Browse files
levon80999levon80999
authored
PHPC-1929: ReadConcern tests need not exhaustively test each constant (#1360)
1 parent 93265d4 commit d6b2fd6

9 files changed

+4
-193
lines changed

‎tests/readConcern/readconcern-bsonserialize-001.phpt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,7 @@ require_once __DIR__ . '/../utils/basic.inc';
77

88
$tests = [
99
new MongoDB\Driver\ReadConcern(),
10-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LINEARIZABLE),
1110
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LOCAL),
12-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::MAJORITY),
13-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::AVAILABLE),
14-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::SNAPSHOT),
1511
];
1612

1713
foreach ($tests as $test) {
@@ -23,9 +19,5 @@ foreach ($tests as $test) {
2319
<?php exit(0); ?>
2420
--EXPECT--
2521
{ }
26-
{ "level" : "linearizable" }
2722
{ "level" : "local" }
28-
{ "level" : "majority" }
29-
{ "level" : "available" }
30-
{ "level" : "snapshot" }
3123
===DONE===

‎tests/readConcern/readconcern-bsonserialize-002.phpt

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,7 @@ require_once __DIR__ . '/../utils/basic.inc';
77

88
$tests = [
99
new MongoDB\Driver\ReadConcern(),
10-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LINEARIZABLE),
1110
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LOCAL),
12-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::MAJORITY),
13-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::AVAILABLE),
14-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::SNAPSHOT),
1511
];
1612

1713
foreach ($tests as $test) {
@@ -24,24 +20,8 @@ foreach ($tests as $test) {
2420
--EXPECTF--
2521
object(stdClass)#%d (%d) {
2622
}
27-
object(stdClass)#%d (%d) {
28-
["level"]=>
29-
string(12) "linearizable"
30-
}
3123
object(stdClass)#%d (%d) {
3224
["level"]=>
3325
string(5) "local"
3426
}
35-
object(stdClass)#%d (%d) {
36-
["level"]=>
37-
string(8) "majority"
38-
}
39-
object(stdClass)#%d (%d) {
40-
["level"]=>
41-
string(9) "available"
42-
}
43-
object(stdClass)#%d (%d) {
44-
["level"]=>
45-
string(8) "snapshot"
46-
}
4727
===DONE===

‎tests/readConcern/readconcern-ctor-001.phpt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ MongoDB\Driver\ReadConcern construction
66
var_dump(new MongoDB\Driver\ReadConcern());
77
var_dump(new MongoDB\Driver\ReadConcern(null));
88
var_dump(new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LOCAL));
9-
var_dump(new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::MAJORITY));
109
var_dump(new MongoDB\Driver\ReadConcern('not-yet-supported'));
1110

1211
?>
@@ -21,10 +20,6 @@ object(MongoDB\Driver\ReadConcern)#%d (%d) {
2120
["level"]=>
2221
string(5) "local"
2322
}
24-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
25-
["level"]=>
26-
string(8) "majority"
27-
}
2823
object(MongoDB\Driver\ReadConcern)#%d (%d) {
2924
["level"]=>
3025
string(17) "not-yet-supported"

‎tests/readConcern/readconcern-debug-001.phpt

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,7 @@ require_once __DIR__ . '/../utils/basic.inc';
77

88
$tests = [
99
new MongoDB\Driver\ReadConcern(),
10-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LINEARIZABLE),
1110
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LOCAL),
12-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::MAJORITY),
13-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::AVAILABLE),
14-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::SNAPSHOT),
1511
];
1612

1713
foreach ($tests as $test) {
@@ -24,24 +20,8 @@ foreach ($tests as $test) {
2420
--EXPECTF--
2521
object(MongoDB\Driver\ReadConcern)#%d (%d) {
2622
}
27-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
28-
["level"]=>
29-
string(12) "linearizable"
30-
}
3123
object(MongoDB\Driver\ReadConcern)#%d (%d) {
3224
["level"]=>
3325
string(5) "local"
3426
}
35-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
36-
["level"]=>
37-
string(8) "majority"
38-
}
39-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
40-
["level"]=>
41-
string(9) "available"
42-
}
43-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
44-
["level"]=>
45-
string(8) "snapshot"
46-
}
4727
===DONE===

‎tests/readConcern/readconcern-getlevel-001.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ MongoDB\Driver\ReadConcern::getLevel()
66
$tests = [
77
null,
88
MongoDB\Driver\ReadConcern::LOCAL,
9-
MongoDB\Driver\ReadConcern::MAJORITY,
109
'not-yet-supported',
1110
];
1211

@@ -21,6 +20,5 @@ foreach ($tests as $test) {
2120
--EXPECT--
2221
NULL
2322
string(5) "local"
24-
string(8) "majority"
2523
string(17) "not-yet-supported"
2624
===DONE===

‎tests/readConcern/readconcern-serialization-001.phpt

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,7 @@ require_once __DIR__ . '/../utils/basic.inc';
1010

1111
$tests = [
1212
new MongoDB\Driver\ReadConcern(),
13-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LINEARIZABLE),
1413
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LOCAL),
15-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::MAJORITY),
16-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::AVAILABLE),
17-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::SNAPSHOT),
1814
];
1915

2016
foreach ($tests as $test) {
@@ -36,17 +32,6 @@ C:26:"MongoDB\Driver\ReadConcern":0:{}
3632
object(MongoDB\Driver\ReadConcern)#%d (%d) {
3733
}
3834

39-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
40-
["level"]=>
41-
string(12) "linearizable"
42-
}
43-
bool(true)
44-
C:26:"MongoDB\Driver\ReadConcern":38:{a:1:{s:5:"level";s:12:"linearizable";}}
45-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
46-
["level"]=>
47-
string(12) "linearizable"
48-
}
49-
5035
object(MongoDB\Driver\ReadConcern)#%d (%d) {
5136
["level"]=>
5237
string(5) "local"
@@ -58,37 +43,4 @@ object(MongoDB\Driver\ReadConcern)#%d (%d) {
5843
string(5) "local"
5944
}
6045

61-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
62-
["level"]=>
63-
string(8) "majority"
64-
}
65-
bool(true)
66-
C:26:"MongoDB\Driver\ReadConcern":33:{a:1:{s:5:"level";s:8:"majority";}}
67-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
68-
["level"]=>
69-
string(8) "majority"
70-
}
71-
72-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
73-
["level"]=>
74-
string(9) "available"
75-
}
76-
bool(true)
77-
C:26:"MongoDB\Driver\ReadConcern":34:{a:1:{s:5:"level";s:9:"available";}}
78-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
79-
["level"]=>
80-
string(9) "available"
81-
}
82-
83-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
84-
["level"]=>
85-
string(8) "snapshot"
86-
}
87-
bool(true)
88-
C:26:"MongoDB\Driver\ReadConcern":33:{a:1:{s:5:"level";s:8:"snapshot";}}
89-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
90-
["level"]=>
91-
string(8) "snapshot"
92-
}
93-
9446
===DONE===

‎tests/readConcern/readconcern-serialization-002.phpt

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,7 @@ require_once __DIR__ . '/../utils/basic.inc';
1010

1111
$tests = [
1212
new MongoDB\Driver\ReadConcern(),
13-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LINEARIZABLE),
1413
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LOCAL),
15-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::MAJORITY),
16-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::AVAILABLE),
17-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::SNAPSHOT),
1814
];
1915

2016
foreach ($tests as $test) {
@@ -34,16 +30,6 @@ O:26:"MongoDB\Driver\ReadConcern":0:{}
3430
object(MongoDB\Driver\ReadConcern)#%d (%d) {
3531
}
3632

37-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
38-
["level"]=>
39-
string(12) "linearizable"
40-
}
41-
O:26:"MongoDB\Driver\ReadConcern":1:{s:5:"level";s:12:"linearizable";}
42-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
43-
["level"]=>
44-
string(12) "linearizable"
45-
}
46-
4733
object(MongoDB\Driver\ReadConcern)#%d (%d) {
4834
["level"]=>
4935
string(5) "local"
@@ -54,34 +40,4 @@ object(MongoDB\Driver\ReadConcern)#%d (%d) {
5440
string(5) "local"
5541
}
5642

57-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
58-
["level"]=>
59-
string(8) "majority"
60-
}
61-
O:26:"MongoDB\Driver\ReadConcern":1:{s:5:"level";s:8:"majority";}
62-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
63-
["level"]=>
64-
string(8) "majority"
65-
}
66-
67-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
68-
["level"]=>
69-
string(9) "available"
70-
}
71-
O:26:"MongoDB\Driver\ReadConcern":1:{s:5:"level";s:9:"available";}
72-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
73-
["level"]=>
74-
string(9) "available"
75-
}
76-
77-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
78-
["level"]=>
79-
string(8) "snapshot"
80-
}
81-
O:26:"MongoDB\Driver\ReadConcern":1:{s:5:"level";s:8:"snapshot";}
82-
object(MongoDB\Driver\ReadConcern)#%d (%d) {
83-
["level"]=>
84-
string(8) "snapshot"
85-
}
86-
8743
===DONE===

‎tests/readConcern/readconcern-set_state-001.phpt

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,10 @@ MongoDB\Driver\ReadConcern::__set_state()
33
--FILE--
44
<?php
55

6-
$tests = [
7-
MongoDB\Driver\ReadConcern::AVAILABLE,
8-
MongoDB\Driver\ReadConcern::LINEARIZABLE,
9-
MongoDB\Driver\ReadConcern::LOCAL,
10-
MongoDB\Driver\ReadConcern::MAJORITY,
11-
MongoDB\Driver\ReadConcern::SNAPSHOT,
12-
];
13-
14-
foreach ($tests as $level) {
15-
var_export(MongoDB\Driver\ReadConcern::__set_state([
16-
'level' => $level,
17-
]));
18-
echo "\n\n";
19-
}
6+
var_export(MongoDB\Driver\ReadConcern::__set_state([
7+
'level' => MongoDB\Driver\ReadConcern::AVAILABLE,
8+
]));
9+
echo "\n\n";
2010

2111
/* Test with level unset */
2212
var_export(MongoDB\Driver\ReadConcern::__set_state([
@@ -31,22 +21,6 @@ echo "\n\n";
3121
%w'level' => 'available',
3222
))
3323

34-
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
35-
%w'level' => 'linearizable',
36-
))
37-
38-
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
39-
%w'level' => 'local',
40-
))
41-
42-
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
43-
%w'level' => 'majority',
44-
))
45-
46-
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
47-
%w'level' => 'snapshot',
48-
))
49-
5024
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
5125
))
5226

‎tests/readConcern/readconcern-var_export-001.phpt

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,7 @@ require_once __DIR__ . '/../utils/basic.inc';
77

88
$tests = [
99
new MongoDB\Driver\ReadConcern(),
10-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LINEARIZABLE),
1110
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::LOCAL),
12-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::MAJORITY),
13-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::AVAILABLE),
14-
new MongoDB\Driver\ReadConcern(MongoDB\Driver\ReadConcern::SNAPSHOT),
1511
];
1612

1713
foreach ($tests as $test) {
@@ -24,19 +20,7 @@ foreach ($tests as $test) {
2420
--EXPECTF--
2521
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
2622
))
27-
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
28-
'level' => 'linearizable',
29-
))
3023
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
3124
'level' => 'local',
3225
))
33-
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
34-
'level' => 'majority',
35-
))
36-
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
37-
'level' => 'available',
38-
))
39-
%r\\?%rMongoDB\Driver\ReadConcern::__set_state(array(
40-
'level' => 'snapshot',
41-
))
4226
===DONE===

0 commit comments

Comments
 (0)