Skip to content

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Sep 5, 2024

This PR removes the matrix strategy, as using it will include the PHP version in the name of the job, making it more difficult to have required check across branches. By setting it as an env var, we can avoid duplication as well have a consistent name for the checks after changing the PHP requirement in #1631.

@alcaeus alcaeus force-pushed the update-clang-job-name branch from 43cf1ae to 3a661a1 Compare September 5, 2024 08:56
@alcaeus alcaeus changed the title Update GHA job name for clang-format Update GitHub Actions job names Sep 5, 2024
@alcaeus alcaeus force-pushed the update-clang-job-name branch from 3a661a1 to 18c6c4b Compare September 5, 2024 08:57
@alcaeus alcaeus requested a review from GromNaN September 5, 2024 08:58
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The other ways of retrieving the PHP version are not suitable for this project.

@alcaeus alcaeus merged commit 4465d24 into mongodb:v1.19 Sep 5, 2024
69 of 70 checks passed
@alcaeus alcaeus deleted the update-clang-job-name branch September 5, 2024 10:29
This was referenced Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants