Bump libmongoc, libmongocrypt and get tests running #1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phpc-2435-libmongoc-2
branch
from
43231f2 to
684802b
Compare
alcaeus
force-pushed
the
phpc-2435-libmongoc-2
branch
from
5d1f8f4 to
9e776cd
Compare
GromNaN
approved these changes
May 22, 2025
alcaeus
merged commit 9ef16ef
into
mongodb:feature/phpc-2435-libmongoc-2
59 of 60 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of PHPC-2435 to update the libmongoc dependency. In this PR:
One part that currently isn't tested is building with system dependencies for libmongoc and libmongocrypt. I've created PHPC-2584 to add tests with system libraries.
I've also updated the version file handling for libmongoc as we no longer need to compute the version but instead use the file from the bundled repo directly. The downside to this is that we no longer have commit granularity when compiling with a development version of libmongoc. Since this is only relevant for internal testing, I think it's an acceptable change as we can easily check the submodule to find the version.
I've also updated the build config to test latest and dev versions of libmongoc with PHP 8.4, but can extract this to a separate PR if we want this change to land sooner.
Note: this PR targets a feature branch, as I anticipate more changes and want to test with PHPLIB before merging this to a stable branch. I'll create a separate draft PR into v2.x after this PR is merged.