use ZSTR_IS_INTERNED() #1849
Merged
use ZSTR_IS_INTERNED() #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Jul 21, 2025
| zval c = *z; | ||
| zval_copy_ctor(&c); | ||
| convert_to_string(&c); | ||
| *pfree = ! IS_INTERNED(Z_STR(c)); |
There was a problem hiding this comment.
For context, this was removed in php/php-src@64e2832
alcaeus
pushed a commit
to alcaeus/mongo-php-driver
that referenced
this pull request
Sep 24, 2025
alcaeus
added a commit
that referenced
this pull request
Sep 25, 2025
* PHPC-2617: Run Github Actions tests on PHP 8.5 * Remove usage of setAccessible in tests * Remove non-canonical cast * Update setup-php-sdk to enable PHP 8.5 builds * Package windows extensions for PHP 8.5 * Don't coerce NAN values to strings due to warnings * use ZSTR_IS_INTERNED() (#1849) --------- Co-authored-by: Remi Collet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS_INTERNEDremoved in 8.5ZSTR_IS_INTERNEDavailable since 7.0