Fix wrong PHP version constraint for pie #1874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an outdated PHP version constraint in composer.json that was not updated when the minimum PHP version was raised to 8.1 in a previous PR. This ensures the extension's composer configuration accurately reflects its PHP requirements.
- Updated PHP version constraint from ">=7.4,<9" to ">=8.1,<9"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GromNaN
approved these changes
Sep 24, 2025
jmikola
approved these changes
Sep 24, 2025
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we bumped the minimum PHP version to 8.1 in #1631, we forgot to update the constraint in composer.json. This can lead to pie picking the wrong version of the extension, followed by a failure to build it. This PR fixes the wrong constraint so future versions don't have the same problem.